[
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651609#comment-15651609
]
ASF GitHub Bot commented on TWILL-138:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87237480
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillPreparer.java
---
@@ -227,15 +227,52 @@
TwillPreparer addSecureStore(SecureStore secureStore);
/**
- * Set the log level for Twill applications running in a container.
+ * Set the root log level for Twill applications in all containers.
*
* @param logLevel the {@link LogEntry.Level} that should be set.
* The level match the {@code Logback} levels.
* @return This {@link TwillPreparer}.
+ * @deprecated Use {@link #setRootLogLevel(LogEntry.Level)} instead.
*/
+ @Deprecated
TwillPreparer setLogLevel(LogEntry.Level logLevel);
/**
+ * Set the root log level for Twill applications in all containers.
+ *
+ * @param logLevel the {@link LogEntry.Level} that should be set.
+ * The level match the {@code Logback} levels.
+ * @return This {@link TwillPreparer}.
+ */
+ TwillPreparer setRootLogLevel(LogEntry.Level logLevel);
+
+ /**
+ * Set the root log level for a particular runnable
+ *
+ * @param runnableName The name of the runnable to set the log level.
+ * @param logLevel the {@link LogEntry.Level} that should be set.
+ * @return This {@link TwillPreparer}.
+ */
+ TwillPreparer setRootLogLevel(String runnableName, LogEntry.Level
logLevel);
--- End diff --
I prefer not to introduce the `setRootLogLevel` and the deprecated
`setLogLevel` replaced with call to `setLogLevel(Map)` with logger name
`Logger.ROOT_LOGGER_NAME` to set root logger log level.
> Runtime change of Application runnable log level
> ------------------------------------------------
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill
> application, next enhancement is to able to send command to update the
> aggregate log level for a particular runnable in a Twill application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
