[
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651615#comment-15651615
]
ASF GitHub Bot commented on TWILL-138:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87238388
--- Diff:
twill-api/src/main/java/org/apache/twill/internal/DefaultTwillRunResources.java
---
@@ -30,17 +35,25 @@
private final int memoryMB;
private final String host;
private final Integer debugPort;
- private final Level logLevel;
+ private final Map<String, LogEntry.Level> logLevels;
+
+ /**
+ * Constructor to create an instance of {@link DefaultTwillRunResources}
with empty log levels.
+ */
+ public DefaultTwillRunResources(int instanceId, String containerId, int
cores, int memoryMB,
+ String host, Integer debugPort) {
+ this(instanceId, containerId, cores, memoryMB, host, debugPort, new
HashMap<String, Level>());
--- End diff --
Use `Collections.<String, Level>emptyMap()` instead.
> Runtime change of Application runnable log level
> ------------------------------------------------
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill
> application, next enhancement is to able to send command to update the
> aggregate log level for a particular runnable in a Twill application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
