[
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651606#comment-15651606
]
ASF GitHub Bot commented on TWILL-138:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87242433
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/ContainerLiveNodeData.java
---
@@ -43,4 +51,15 @@ public String getHost() {
public String getDebugPort() {
return debugPort;
}
+
+ public Map<String, LogEntry.Level> getLogLevels() {
+ return logLevels;
+ }
+
+ public void updateLogLevels(Map<String, LogEntry.Level> logLevels,
boolean isReset) {
+ if (isReset) {
--- End diff --
This is not a good way overloading the responsibility of this method.
Better have a separate method for resetting (and that mirrors the actual
functionality being exposed through the public API).
> Runtime change of Application runnable log level
> ------------------------------------------------
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill
> application, next enhancement is to able to send command to update the
> aggregate log level for a particular runnable in a Twill application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
