[
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15664789#comment-15664789
]
ASF GitHub Bot commented on TWILL-138:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87872004
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/json/TwillRunResourcesCodec.java
---
@@ -66,13 +67,14 @@ public JsonElement serialize(TwillRunResources src,
Type typeOfSrc, JsonSerializ
public TwillRunResources deserialize(JsonElement json, Type typeOfT,
JsonDeserializationContext
context) throws JsonParseException {
JsonObject jsonObj = json.getAsJsonObject();
+ Map<String, LogEntry.Level> logLevels =
+ context.deserialize(jsonObj.get("logLevels"), new
TypeToken<Map<String, LogEntry.Level>>() { }.getType());
--- End diff --
Since constants are defined, we should use those constants in
deserialization as well.
> Runtime change of Application runnable log level
> ------------------------------------------------
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill
> application, next enhancement is to able to send command to update the
> aggregate log level for a particular runnable in a Twill application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
