[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101982#comment-16101982
]
ASF GitHub Bot commented on TWILL-240:
--------------------------------------
Github user sameetandpotatoes commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r129643180
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -103,6 +105,8 @@ public Integer apply(BitSet input) {
private final Table<String, String, TwillContainerController> containers;
// Map from runnableName to a BitSet, with the <instanceId> bit turned
on for having an instance running.
+ private final String twillAppName;
--- End diff --
The comment above this line should be moved down to above the
`runnableInstances` variable
> Improve EventHandler to handle more application lifecycle events
> ----------------------------------------------------------------
>
> Key: TWILL-240
> URL: https://issues.apache.org/jira/browse/TWILL-240
> Project: Apache Twill
> Issue Type: New Feature
> Reporter: Chengfeng Mao
> Assignee: Chengfeng Mao
>
> Application Master should be able to run application specific code when
> certain lifecycle events happen by calling methods from EventHandler. For
> instance, when the app first starts, completes, aborts and etc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
