[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107645#comment-16107645
]
ASF GitHub Bot commented on TWILL-240:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r130407739
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -205,8 +208,9 @@ private RunningContainers
createRunningContainers(ContainerId appMasterContainer
Integer.parseInt(System.getenv(EnvKeys.YARN_CONTAINER_MEMORY_MB)),
appMasterHost, null);
String appId =
appMasterContainerId.getApplicationAttemptId().getApplicationId().toString();
- return new RunningContainers(appId, appMasterResources, zkClient,
applicationLocation,
- twillSpec.getRunnables(), twillRuntimeSpec.getMaxRetries());
+ return new RunningContainers(twillRuntimeSpec.getTwillAppName(),
twillRuntimeSpec.getTwillAppRunId(),
--- End diff --
Better just pass the `twillRuntimeSpec` to the `RunningContainers` instead
of getting individual entries one by one. It can replace the
`twillRuntimeSpec.getXXX` and `twillSpec.getRunnables`.
> Improve EventHandler to handle more application lifecycle events
> ----------------------------------------------------------------
>
> Key: TWILL-240
> URL: https://issues.apache.org/jira/browse/TWILL-240
> Project: Apache Twill
> Issue Type: New Feature
> Reporter: Chengfeng Mao
> Assignee: Chengfeng Mao
>
> Application Master should be able to run application specific code when
> certain lifecycle events happen by calling methods from EventHandler. For
> instance, when the app first starts, completes, aborts and etc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
