[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101983#comment-16101983
]
ASF GitHub Bot commented on TWILL-240:
--------------------------------------
Github user sameetandpotatoes commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r129643121
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -267,6 +281,9 @@ void stopByIdAndWait(String runnableName, int
instanceId) {
resourceReport.removeRunnableResources(runnableName, containerId);
containerChange.signalAll();
+ if (eventHandler != null) {
+ eventHandler.containerLaunched(twillAppName, runId,
runnableName, instanceId, containerId);
--- End diff --
Typo - should be `containerStopped`
> Improve EventHandler to handle more application lifecycle events
> ----------------------------------------------------------------
>
> Key: TWILL-240
> URL: https://issues.apache.org/jira/browse/TWILL-240
> Project: Apache Twill
> Issue Type: New Feature
> Reporter: Chengfeng Mao
> Assignee: Chengfeng Mao
>
> Application Master should be able to run application specific code when
> certain lifecycle events happen by calling methods from EventHandler. For
> instance, when the app first starts, completes, aborts and etc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
