[ https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102010#comment-16102010 ]
ASF GitHub Bot commented on TWILL-240: -------------------------------------- Github user maochf commented on a diff in the pull request: https://github.com/apache/twill/pull/58#discussion_r129647384 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java --- @@ -222,6 +226,7 @@ protected void doStart() throws Exception { // initialize the event handler, if it fails, it will fail the application. if (eventHandler != null) { eventHandler.initialize(new BasicEventHandlerContext(twillSpec.getEventHandler())); + eventHandler.started(twillRuntimeSpec.getTwillAppName(), twillRuntimeSpec.getTwillAppRunId()); --- End diff -- If initialization fails, then the whole app will fail. `TwillController` should be able to catch this > Improve EventHandler to handle more application lifecycle events > ---------------------------------------------------------------- > > Key: TWILL-240 > URL: https://issues.apache.org/jira/browse/TWILL-240 > Project: Apache Twill > Issue Type: New Feature > Reporter: Chengfeng Mao > Assignee: Chengfeng Mao > > Application Master should be able to run application specific code when > certain lifecycle events happen by calling methods from EventHandler. For > instance, when the app first starts, completes, aborts and etc. -- This message was sent by Atlassian JIRA (v6.4.14#64029)