Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/208#issuecomment-203834473
@elbamos thank you, it looks great now.
Could you please take care of the last step - updating `LICENSE` files,
while I'll focus on
[ZEPPELIN-776](https://issues.apache.org/jira/browse/ZEPPELIN-776) ?
Here is updated list, just a few things left
- [x] ~~master and this branch have diverged: we need to either merge
master in here, or rebase it on top of the master~~
- [x] ~~revert deletion of `ZeppelinSparkClusterTest.java`~~
- [ ] make CI green
It's almost done, except for
[ZEPPELIN-776](https://issues.apache.org/jira/browse/ZEPPELIN-776). I will be
looking into today\tomorrow and will post here. If we could not identify the
reason today - please feel free to user JUnit Ignore to take it out of the test
suite in this PR
- [x] determine the license for files, forked from other open-sourced
projects
* [x] `r/src/main/scala/scala/Console.scala` - scala
[BSD](http://scala-lang.org/license.html)
* [x]
`r/src/main/scala/org/apache/zeppelin/rinterpreter/rscala/Package.scala` rscala
[BSD](https://cran.r-project.org/web/packages/rscala/index.html)
* [x]
`r/src/main/scala/org/apache/zeppelin/rinterpreter/rscala/RClient.scala` rscala
[BSD](https://cran.r-project.org/web/packages/rscala/index.html)
* [x] `r/R/rzeppelin/R/common.R` rscala
[BSD](https://github.com/apache/incubator-zeppelin/pull/208/files#r57993531)
* [x] `r/R/rzeppelin/R/globals.R`
[rscala](https://github.com/cran/rscala/blob/master/R/globals.R)
[BSD](https://cran.r-project.org/web/packages/rscala/index.html)
* [x] `r/R/rzeppelin/R/protocol.R`
[rscala](https://github.com/cran/rscala/blob/master/R/protocol.R)
[BSD](https://cran.r-project.org/web/packages/rscala/index.html)
* [x] `r/R/rzeppelin/R/rServer.R` rscala
[BSD](https://github.com/apache/incubator-zeppelin/pull/208/files#r57994431)
* [x] `r/R/rzeppelin/R/scalaInterpreter.R` rscala
[BSD](https://github.com/apache/incubator-zeppelin/pull/208/files#r57994608)
* [x] `r/R/rzeppelin/R/zzz.R` rscala
[BSD](https://github.com/apache/incubator-zeppelin/pull/208/files#r57994684)
- [ ] update `LICENSE` files
- [ ] add 2 new files under `licenses/LICENSE-[project]-[version].txt`
with full text of the above licenses (for rscala - bolerplate text from
https://cran.r-project.org/web/licenses/BSD_3_clause with 3 lines replaced from
https://cran.r-project.org/web/packages/rscala/LICENSE,
http://www.scala-lang.org/download/#License for Scala)
- [ ] list each license + list of file paths in `./LICENSE`
```
========================================================================
BSD-style licenses
========================================================================
The following components are provided under the BSD-style License. See
project link for details.
The text of each license is also included at
licenses/LICENSE-[project]-[version].txt.
(BSD 3 Clause) next portions of rscala 1.0.6
(https://dahl.byu.edu/software/rscala/) -
https://cran.r-project.org/web/packages/rscala/index.html
r/R/rzeppelin/R/{common.R, globals.R <all the rest of files from the
list> }
r/src/main/scala/org/apache/zeppelin/rinterpreter/rscala/{Package.scala,
RClient.scala}
(BSD 3 Clause) next portions of Scala
http://www.scala-lang.org/download/#License ...<more details here>
r/src/main/scala/scala/Console.scala
```
- [ ] for now, remove rscala from
`./zeppelin-distribution/src/bin_license/LICENSE`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
