Thanks Mahadev. It looks like the patch on 1560 is not a fix - its a test that reproduces the bug.
On Thu, Oct 11, 2012 at 2:45 PM, Mahadev Konar <maha...@hortonworks.com> wrote: > Thanks Alex for bringing it up. Ill hold the release for now. I see a > patch on 1560. Ill take a look and we'll see how to roll this into > 3.4.5. > > thanks > mahadev > > On Thu, Oct 11, 2012 at 2:42 PM, Alexander Shraer <shra...@gmail.com> wrote: >> Hi Mahadev, >> >> ZOOKEEPER-1560 and ZOOKEEPER-1561 indicate a potentially serious issue, >> introduced recently in ZOOKEEPER-1437. Please consider this w.r.t. the >> 3.4.5 release. >> >> Best Regards, >> Alex >> >> On Wed, Oct 10, 2012 at 10:38 PM, Mahadev Konar <maha...@hortonworks.com> >> wrote: >>> I think we have waited enough. Closing the vote now. >>> >>> With 5 +1's (3 binding) the vote passes. I will do the needful for >>> getting the release out. >>> >>> Thanks for voting folks. >>> >>> mahadev >>> >>> On Wed, Oct 10, 2012 at 9:04 AM, Flavio Junqueira <f...@yahoo-inc.com> >>> wrote: >>>> +1 >>>> >>>> -Flavio >>>> >>>> On Oct 8, 2012, at 7:05 AM, Mahadev Konar wrote: >>>> >>>>> Given Eugene's findings on ZOOKEEPER-1557, I think we can continue >>>>> rolling the current RC out. Others please vote on the thread if you >>>>> see any issues with that. Folks who have already voted, please re vote >>>>> in case you have a change of opinion. >>>>> >>>>> As for myself, I ran a couple of tests with the RC using open jdk 7 >>>>> and things seem to work. >>>>> >>>>> +1 from my side. Pat/Ben/Flavio/others what do you guys think? >>>>> >>>>> thanks >>>>> mahadev >>>>> >>>>> On Sun, Oct 7, 2012 at 8:34 AM, Ted Yu <yuzhih...@gmail.com> wrote: >>>>>> Currently ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 are >>>>>> using >>>>>> lock ZooKeeper-solaris. >>>>>> I think ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 should >>>>>> use >>>>>> a separate lock since they wouldn't run on a Solaris machine. >>>>>> I didn't seem to find how a new lock name can be added. >>>>>> >>>>>> Recent builds for ZooKeeper_branch34_openjdk7 and ZooKeeper_branch34_jdk7 >>>>>> have been green. >>>>>> >>>>>> Cheers >>>>>> >>>>>> On Sun, Oct 7, 2012 at 6:56 AM, Patrick Hunt <ph...@apache.org> wrote: >>>>>> >>>>>>> I've seen that before, it's a flakey test that's unrelated to the sasl >>>>>>> stuff. >>>>>>> >>>>>>> Patrick >>>>>>> >>>>>>> On Sat, Oct 6, 2012 at 2:25 PM, Ted Yu <yuzhih...@gmail.com> wrote: >>>>>>>> I saw one test failure: >>>>>>>> >>>>>>>> >>>>>>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/9/testReport/org.apache.zookeeper.server.quorum/QuorumPeerMainTest/testHighestZxidJoinLate/ >>>>>>>> >>>>>>>> FYI >>>>>>>> >>>>>>>> On Sat, Oct 6, 2012 at 7:16 AM, Ted Yu <yuzhih...@gmail.com> wrote: >>>>>>>> >>>>>>>>> Up in ZOOKEEPER-1557, Eugene separated one test out and test failure >>>>>>> seems >>>>>>>>> to be gone. >>>>>>>>> >>>>>>>>> For ZooKeeper_branch34_jdk7, the two failed builds: >>>>>>>>> #10 corresponded to ZooKeeper_branch34_openjdk7 build #7, >>>>>>>>> #8 corresponded to ZooKeeper_branch34_openjdk7 build #5 >>>>>>>>> where tests failed due to BindException >>>>>>>>> >>>>>>>>> Cheers >>>>>>>>> >>>>>>>>> >>>>>>>>> On Sat, Oct 6, 2012 at 7:06 AM, Patrick Hunt <ph...@apache.org> wrote: >>>>>>>>> >>>>>>>>>> Yes. Those ubuntu machines have two slots each. If both tests run at >>>>>>>>>> the same time... bam. >>>>>>>>>> >>>>>>>>>> I just added exclusion locks to the configuration of these two jobs, >>>>>>>>>> that should help. >>>>>>>>>> >>>>>>>>>> Patrick >>>>>>>>>> >>>>>>>>>> On Fri, Oct 5, 2012 at 8:58 PM, Ted Yu <yuzhih...@gmail.com> wrote: >>>>>>>>>>> I think that was due to the following running on the same machine at >>>>>>> the >>>>>>>>>>> same time: >>>>>>>>>>> >>>>>>>>>>> Building remotely on ubuntu4 >>>>>>>>>>> <https://builds.apache.org/computer/ubuntu4> in workspace >>>>>>>>>>> /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7 >>>>>>>>>>> >>>>>>>>>>> We should introduce randomized port so that test suite can execute >>>>>>>>>>> in >>>>>>>>>>> parallel. >>>>>>>>>>> >>>>>>>>>>> Cheers >>>>>>>>>>> >>>>>>>>>>> On Fri, Oct 5, 2012 at 8:55 PM, Ted Yu <yuzhih...@gmail.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> Some tests failed in build 8 due to (See >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>> >>>>>>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/8/testReport/org.apache.zookeeper.server/ZxidRolloverTest/testRolloverThenRestart/ >>>>>>>>>> ): >>>>>>>>>>>> >>>>>>>>>>>> java.lang.RuntimeException: java.net.BindException: Address already >>>>>>> in >>>>>>>>>> use >>>>>>>>>>>> at >>>>>>>>>> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:118) >>>>>>>>>>>> at >>>>>>>>>> >>>>>>> org.apache.zookeeper.server.ZxidRolloverTest.setUp(ZxidRolloverTest.java:63) >>>>>>>>>>>> Caused by: java.net.BindException: Address already in use >>>>>>>>>>>> at sun.nio.ch.Net.bind0(Native Method) >>>>>>>>>>>> at sun.nio.ch.Net.bind(Net.java:344) >>>>>>>>>>>> at sun.nio.ch.Net.bind(Net.java:336) >>>>>>>>>>>> at >>>>>>>>>> >>>>>>> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:199) >>>>>>>>>>>> at >>>>>>>>>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74) >>>>>>>>>>>> at >>>>>>>>>> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67) >>>>>>>>>>>> at >>>>>>>>>> >>>>>>> org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:95) >>>>>>>>>>>> at >>>>>>>>>> >>>>>>> org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:125) >>>>>>>>>>>> at >>>>>>>>>> >>>>>>> org.apache.zookeeper.server.quorum.QuorumPeer.<init>(QuorumPeer.java:517) >>>>>>>>>>>> at >>>>>>>>>> org.apache.zookeeper.test.QuorumUtil.<init>(QuorumUtil.java:113) >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On Fri, Oct 5, 2012 at 9:56 AM, Patrick Hunt <ph...@apache.org> >>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> fwiw: I setup jdk7 and openjdk7 jobs last night for branch34 on >>>>>>>>>>>>> jenkins and they are looking good so far: >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>> >>>>>>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_jdk7/ >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>> >>>>>>> https://builds.apache.org//view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_openjdk7/ >>>>>>>>>>>>> >>>>>>>>>>>>> Patrick >>>>>>>>>>>>> >>>>>>>>>>>>> On Thu, Oct 4, 2012 at 11:17 PM, Patrick Hunt <ph...@apache.org> >>>>>>>>>> wrote: >>>>>>>>>>>>>> Doesn't look good, failed a second time: >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>> >>>>>>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-jdk7/408/ >>>>>>>>>>>>>> >>>>>>>>>>>>>> java.util.concurrent.TimeoutException: Did not connect >>>>>>>>>>>>>> at >>>>>>>>>>>>> >>>>>>>>>> >>>>>>> org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:129) >>>>>>>>>>>>>> at >>>>>>>>>>>>> >>>>>>>>>> >>>>>>> org.apache.zookeeper.test.WatcherTest.testWatchAutoResetWithPending(WatcherTest.java:199) >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Patrick >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Thu, Oct 4, 2012 at 4:15 PM, Mahadev Konar < >>>>>>>>>> maha...@hortonworks.com> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>> Good point Ted. >>>>>>>>>>>>>>> Eugene, >>>>>>>>>>>>>>> Would you be able to take a quick look and point out the threat >>>>>>>>>>>>> level? :) >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I have kicked off new build to see if its reproducible or not. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> thanks >>>>>>>>>>>>>>> mahadev >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Thu, Oct 4, 2012 at 4:10 PM, Ted Yu <yuzhih...@gmail.com> >>>>>>>>>> wrote: >>>>>>>>>>>>>>>> Should ZOOKEEPER-1557 be given some time so that we track down >>>>>>>>>> root >>>>>>>>>>>>> cause ? >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Wed, Oct 3, 2012 at 11:34 PM, Patrick Hunt < >>>>>>> ph...@apache.org> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> +1, sig/xsum are correct, ran rat an that looked good. All the >>>>>>>>>> unit >>>>>>>>>>>>>>>>> tests pass for me on jdk6 and openjdk7 (ubuntu 12.04). Also >>>>>>> ran >>>>>>>>>>>>>>>>> 1/3/5/13 server clusters using openjdk7, everything seems to >>>>>>> be >>>>>>>>>>>>>>>>> working. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Patrick >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On Sun, Sep 30, 2012 at 11:15 AM, Mahadev Konar < >>>>>>>>>>>>> maha...@hortonworks.com> >>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>> Hi all, >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> I have created a candidate build for ZooKeeper 3.4.5. 2 >>>>>>>>>> JIRAs are >>>>>>>>>>>>>>>>>> addressed in this release. This includes the critical >>>>>>> bugfix >>>>>>>>>>>>>>>>> ZOOKEEPER-1550 >>>>>>>>>>>>>>>>>> which address the client connection issue. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> *** Please download, test and VOTE before the >>>>>>>>>>>>>>>>>> *** vote closes 12:00 midnight PT on Friday, Oct 5th.*** >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Note that I am extending the vote period for a little >>>>>>> longer so >>>>>>>>>>>>> that >>>>>>>>>>>>>>>>>> folks get time to test this out. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>> http://people.apache.org/~mahadev/zookeeper-3.4.5-candidate-0/ >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Should we release this? >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> thanks >>>>>>>>>>>>>>>>>> mahadev >>>>>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>> >>>>
