-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25160/#review119818
-----------------------------------------------------------




./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
 (line 88)
<https://reviews.apache.org/r/25160/#comment181166>

    can you simplify this ?



./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
 (line 126)
<https://reviews.apache.org/r/25160/#comment181167>

    not necessarily read, change the variable name



./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
 (line 132)
<https://reviews.apache.org/r/25160/#comment181168>

    Briefly explain test plan.



./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
 (line 220)
<https://reviews.apache.org/r/25160/#comment181169>

    wrong error message



./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
 (line 242)
<https://reviews.apache.org/r/25160/#comment181170>

    queueRequests -> queuedRequests


- Alexander Shraer


On Feb. 19, 2016, 6:02 a.m., Kfir Lev-Ari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25160/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 6:02 a.m.)
> 
> 
> Review request for zookeeper, Raul Gutierrez Segales and Alexander Shraer.
> 
> 
> Repository: zookeeper
> 
> 
> Description
> -------
> 
> Please see https://issues.apache.org/jira/browse/ZOOKEEPER-2024
> 
> 
> Diffs
> -----
> 
>   ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 
> 1726708 
>   
> ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
>  1726708 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 
> 1726708 
> 
> Diff: https://reviews.apache.org/r/25160/diff/
> 
> 
> Testing
> -------
> 
> The attached unit tests, as well as the system test found in 
> https://issues.apache.org/jira/browse/ZOOKEEPER-2023. 
> 
> 
> Thanks,
> 
> Kfir Lev-Ari
> 
>

Reply via email to