----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review125537 -----------------------------------------------------------
./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java (line 98) <https://reviews.apache.org/r/25160/#comment188387> hmm, should preallocate memory for this hashmap? imagine this scenario (which i've seen in production): * you have > 100K sessions * a very bad partition happens * after a long election clients start reconnecting creating and reading more than 200k ephemerals znodes and setting more than 600k watches wonder how reallocating this hashmap as those requests come in would work... ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java (line 106) <https://reviews.apache.org/r/25160/#comment188383> nit: trailing whitespace ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java (line 129) <https://reviews.apache.org/r/25160/#comment188384> nit: trailing whitespace (or tab?) - Raul Gutierrez Segales On March 26, 2016, 5:37 a.m., Kfir Lev-Ari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25160/ > ----------------------------------------------------------- > > (Updated March 26, 2016, 5:37 a.m.) > > > Review request for zookeeper, Raul Gutierrez Segales and Alexander Shraer. > > > Repository: zookeeper > > > Description > ------- > > Please see https://issues.apache.org/jira/browse/ZOOKEEPER-2024 > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java > 1726708 > > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java > 1726708 > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java > 1726708 > > Diff: https://reviews.apache.org/r/25160/diff/ > > > Testing > ------- > > The attached unit tests, as well as the system test found in > https://issues.apache.org/jira/browse/ZOOKEEPER-2023. > > > Thanks, > > Kfir Lev-Ari > >
