> On March 26, 2016, 6:38 p.m., Raul Gutierrez Segales wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, > > line 99 > > <https://reviews.apache.org/r/25160/diff/27/?file=1315415#file1315415line99> > > > > hmm, should preallocate memory for this hashmap? imagine this scenario > > (which i've seen in production): > > > > * you have > 100K sessions > > * a very bad partition happens > > * after a long election clients start reconnecting creating and reading > > more than 200k ephemerals znodes and setting more than 600k watches > > > > wonder how reallocating this hashmap as those requests come in would > > work... > > Alexander Shraer wrote: > Sounds like a good idea, what would be a good initial size ? given that > not everyone run ZK with som many client sessions...
Initialized to 10000 for now. If you have better suggestions let me know. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review125537 ----------------------------------------------------------- On March 26, 2016, 7:06 p.m., Kfir Lev-Ari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25160/ > ----------------------------------------------------------- > > (Updated March 26, 2016, 7:06 p.m.) > > > Review request for zookeeper, Raul Gutierrez Segales and Alexander Shraer. > > > Repository: zookeeper > > > Description > ------- > > Please see https://issues.apache.org/jira/browse/ZOOKEEPER-2024 > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java > 1726708 > > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java > 1726708 > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java > 1726708 > > Diff: https://reviews.apache.org/r/25160/diff/ > > > Testing > ------- > > The attached unit tests, as well as the system test found in > https://issues.apache.org/jira/browse/ZOOKEEPER-2023. > > > Thanks, > > Kfir Lev-Ari > >
