> On March 25, 2016, 9:05 a.m., Rakesh R wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, > > line 269 > > <https://reviews.apache.org/r/25160/diff/26/?file=1259184#file1259184line269> > > > > Should the admin take any action on seeing this error? I'm interested > > to know the severity of this state, say monitoring tool or admin detect > > this error message. > > Kfir Lev-Ari wrote: > This check (request != null) should never be true and may indicate a bug, > so we log it. > If it is detected the code will skip the request instead of crashing with > null pointer as before. > This error doesn't indicate an inconsistent state so we decided to just > skip the request. > > Alexander Shraer wrote: > Following Raul's comment, changing this to throw an exception.
OK, agreed. > On March 25, 2016, 9:05 a.m., Rakesh R wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, > > line 285 > > <https://reviews.apache.org/r/25160/diff/26/?file=1259184#file1259184line285> > > > > Here its throwing exception and exits CommitProcessor. Could you please > > explain me about this case and the reason to exit rather than failing the > > request alone. > > Kfir Lev-Ari wrote: > This error indicates an inconsistency since we know we lost an operation, > so we decided to throw an exception instead of silently skipping it. ok, fine. - Rakesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review125396 ----------------------------------------------------------- On March 26, 2016, 7:06 p.m., Kfir Lev-Ari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25160/ > ----------------------------------------------------------- > > (Updated March 26, 2016, 7:06 p.m.) > > > Review request for zookeeper, Raul Gutierrez Segales and Alexander Shraer. > > > Repository: zookeeper > > > Description > ------- > > Please see https://issues.apache.org/jira/browse/ZOOKEEPER-2024 > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java > 1726708 > > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java > 1726708 > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java > 1726708 > > Diff: https://reviews.apache.org/r/25160/diff/ > > > Testing > ------- > > The attached unit tests, as well as the system test found in > https://issues.apache.org/jira/browse/ZOOKEEPER-2023. > > > Thanks, > > Kfir Lev-Ari > >
