----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review125396 -----------------------------------------------------------
./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java (line 223) <https://reviews.apache.org/r/25160/#comment188191> Should the admin take any action on seeing this error? I'm interested to know the severity of this state, say monitoring tool or admin detect this error message. ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java (line 239) <https://reviews.apache.org/r/25160/#comment188184> Here its throwing exception and exits CommitProcessor. Could you please explain me about this case and the reason to exit rather than failing the request alone. ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java (line 250) <https://reviews.apache.org/r/25160/#comment188185> How about extracting this to a separate method as this logic is duplciated twice. - Rakesh R On Feb. 19, 2016, 12:56 p.m., Kfir Lev-Ari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25160/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2016, 12:56 p.m.) > > > Review request for zookeeper, Raul Gutierrez Segales and Alexander Shraer. > > > Repository: zookeeper > > > Description > ------- > > Please see https://issues.apache.org/jira/browse/ZOOKEEPER-2024 > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java > 1726708 > > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java > 1726708 > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java > 1726708 > > Diff: https://reviews.apache.org/r/25160/diff/ > > > Testing > ------- > > The attached unit tests, as well as the system test found in > https://issues.apache.org/jira/browse/ZOOKEEPER-2023. > > > Thanks, > > Kfir Lev-Ari > >
