So although I tried to keep the user avatars as primary elements in the UI, in the end I will change my vote to the event based layout.
The first problem was the grouping we have. If we were to display individual entries for each user that layout might work, since we would not have the generic group avatar. But this was not the main problem. The main problem is scalability. Since we need to display the event and application, having also the avatar was putting the application icon as a tertiary element. Was very small and not readable at all. Today I was trying to represent how an application upgrade would look like. You can check http://design.xwiki.org/xwiki/bin/view/Proposal/NotificationsImprovements9xTypes#HApplicationsevents So what I am proposing is a mix of the 2 layouts, see http://design.xwiki.org/xwiki/bin/download/Proposal/NotificationsImprovements9xTypes/event_app_primary.png For normal pages the event will be displayed as primary; while for application events the application is primary. I made this change taking into consideration Vincent's notes about confusion of knowing who sent the event. I think this way is easier to read and understand from where the event is coming from. So let me know what think about this latest layout. http://design.xwiki.org/xwiki/bin/download/Proposal/NotificationsImprovements9xTypes/event_app_primary_extension.png Avatars are still present, but not primary. Applications are displayed. Prototype at https://jsfiddle.net/risherry/t1nv2uoz/ Thanks, Caty On Tue, Oct 31, 2017 at 11:11 AM, Guillaume Delhumeau < [email protected]> wrote: > 2017-10-30 18:59 GMT+01:00 Vincent Massol <[email protected]>: > > > > > > On 30 Oct 2017, at 18:46, Ecaterina Moraru (Valica) <[email protected] > > > > wrote: > > > > > > I've iterated how it would look inside the mail, see > > > http://design.xwiki.org/xwiki/bin/view/Proposal/ > > NotificationsImprovements9xEmail#HProposal2 > > > > Thanks Caty. In your proposal I don’t see where you put the TOC for > > non-page events. > > > > > Still haven't found a solution for the avatar's group image, but the > > thing > > > is that when the user selects to receive the diffs in the mail, this > user > > > grouping is confusing. > > > > Indeed, we cannot group diffs I think. The diff needs to be under each > > change, not under the whole grouped change. > > > > This is not the case in the watchlist. In the watchlist, you see the diff > for the whole changes on each listed page. I don't think you want to have > each individual diff when you look on what's changed in the wiki. > > > > > > > For some events we display just the last change, not all the changes, > or > > we > > > display the whole diff, so it's kind of hard to tell which user did > what. > > > > > > A solution would be to display the entries separate, each with its own > > > diff. Not sure what is the best approach. > > > > Yep > > > > Thanks > > -Vincent > > > > > > > > Thanks, > > > Caty > > > > > > On Mon, Oct 30, 2017 at 4:26 PM, Vincent Massol <[email protected]> > > wrote: > > > > > >> > > >>> On 30 Oct 2017, at 15:15, Ecaterina Moraru (Valica) < > [email protected] > > > > > >> wrote: > > >>> > > >>> On Mon, Oct 30, 2017 at 3:50 PM, Vincent Massol <[email protected]> > > >> wrote: > > >>> > > >>>> > > >>>>> On 30 Oct 2017, at 12:27, Ecaterina Moraru (Valica) < > > [email protected] > > >>> > > >>>> wrote: > > >>>>> > > >>>>> On Mon, Oct 30, 2017 at 12:32 PM, Vincent Massol < > [email protected] > > > > > >>>> wrote: > > >>>>> > > >>>>>> Hi Caty, > > >>>>>> > > >>>>>> Thanks! > > >>>>>> > > >>>>>> There’ s something I don’t understand. Sometimes you have 2 icons > > and > > >>>>>> sometimes only 1. > > >>>>>> > > >>>>> > > >>>>> There is only 1 icon if the action is done by the "Pages" app, > coming > > >>>> from > > >>>>> XWiki. > > >>>>> I've considered that this is the main/default app, so we don't > > display > > >>>> it. > > >>>>> It's the default. > > >>>>> So if you have created, edited, delete, commented on a normal page, > > you > > >>>> get > > >>>>> just the event action. > > >>>>> If the page is special, coming from a particular application, then > > you > > >>>> have > > >>>>> an additional icon, marking the application. > > >>>> > > >>>> I find this highly confusing for my part :) > > >>>> > > >>>>> For me we always need 2 icons: > > >>>>>> * one to represent the application (e.g. Pages app, Blog app, etc) > > >>>>>> * one to represent the event (e.g. for the Paged app: Create, > > Modify, > > >>>>>> Delete, Comment. For the Blog app: Publish a blog post) > > >>>>>> > > >>>>>> So if we display the avatar this means 3 icons: one for the > avatar, > > >> one > > >>>>>> for the app and one for the event. Maybe that’s a bit too much. > > >>>>>> > > >>>>>> Right now, on the proposals I see, I find it very confusing and I > > can > > >>>>>> never figure out which is the app and which is the event. > > >>>>>> > > >>>>>> I think I would prefer the following: > > >>>>>> * On the left, avatar in big + app in smaller on top of it > > >>>>>> * On the right, icon for the event. Actually the icon could be in > > >>>> addition > > >>>>>> to the “text” (i.e. “edited by”, “published by”, “commented by”, > > >>>> “deleted > > >>>>>> by”, etc) or we could drop the icon for the event and only keep > the > > >>>> text. > > >>>>>> > > >>>>> > > >>>>> I wouldn't drop the event icon since that's the most important > piece > > of > > >>>>> information now. > > >>>> > > >>>> I would not drop it but it’s already contained in the text on the > > right > > >> so > > >>>> that’s duplication. > > >>>> > > >>>> I’d use the avatar + the app and leave the event icon on the right > or > > >>>> simply drop it in favor of the text (either one). > > >>>> > > >>>>> The grouping is done by page and by event. > > >>>>> You want to know if someone deleted a new entry or just edited in a > > >> rapid > > >>>>> way, without the need to read the text. > > >>>> > > >>>> I’d prefer to see who did something and what they modified. That’s > > >> really > > >>>> how I use XWiki’s AS the most personally. > > >>>> > > >>>> If the text is not visual enough the event icon is ok too but I > > wouldn’t > > >>>> put it on the left. > > >>>> > > >>>> In any case, you need consistency and all entries need to look the > > same. > > >>>> We must not have special cases as it makes it very hard to > understand. > > >>>> > > >>> > > >>> For me it was confusing seeing "Pages", since in XWiki everything is > a > > >> page > > >>> and I don't have any application called Pages. I saw the addition of > > >>> "Pages" as redundant. > > >>> > > >>> > > >>>> > > >>>>> > > >>>>>> In your variations I don’t see one where the app icon is on the > > left. > > >>>>>> > > >>>>> > > >>>>> I have put all the icons on the left in order to be easier to scan > > for > > >>>> them > > >>>>> in collapsed and expanded form. Having the icons on the right made > > the > > >>>>> layout very centered-heavy + you didn't had the extremities in > order > > to > > >>>>> scan for them. > > >>>>> > > >>>>> So Guillaume and Clement like the event-focused view. > > >>>>> > > >>>>> I don't particularly like the big event icons. I find them more > cold > > >> and > > >>>>> less personal. So I prefer the users-centered version. > > >>>> > > >>>> Same here for the same reason, but… (see below) > > >>>> > > >>>>> I like: > > >>>>> http://design.xwiki.org/xwiki/bin/download/Proposal/ > > >>>> NotificationsImprovements9xTypes/userCentered_smallAvatars_ > > reverse.png > > >>>> > > >>>> I don’t like the generic group image, it breaks the nice UI with > > >> avatars. > > >>>> We could maybe resize the avatars and display up to 4 and if beyond > > then > > >>>> display some continuations symbol. > > >>>> > > >>> > > >>> Not really sure how to display 4 avatars + in a nice way, while still > > >> being > > >>> the main focus. > > >> > > >> There’s another problem too actually. Not all events are related to > > >> people. For example the “A new version of XWiki is available” event > > would > > >> not have an avatar. However we could decide to use an “X” icon, > > >> representing the xwiki.org entity/avatar. > > >> > > >> What I wouldn’t like is some generic image such as a bland group > image. > > I > > >> find that this breaks the concept of showing avatars. > > >> > > >> Thanks > > >> -Vincent > > >> > > >>> > > >>>>> Now I haven't created versions for all the combinations, but we > > should > > >>>>> decide if: > > >>>>> - we want user focused vs. event focused layout > > >>>>> - expanded version should have users or events on the left; > > >>>>> - the summary should contain avatars or not for the users > (important > > >> when > > >>>>> there is a single user that did the event); > > >>>>> - if / when we combine the users (when we have more than 2/3 users; > > >>>> always; > > >>>>> > > >>>>> I am lacking some information in order to get some statistical > > >> decisions. > > >>>>> For example, in practice: > > >>>>> - we have more individual events or more events done by multiple > > >> people? > > >>>>> - how common is to group also events? the example with blog > published > > >>>> that > > >>>>> also has the create. Do we really need to display them? Also when > > >>>> creating > > >>>>> an user profile we launch a multitude of edit events, should all > > those > > >> be > > >>>>> displayed? > > >>>>> > > >>>>> Regarding the user vs. event focused layout: it's just in the > layout > > >> and > > >>>>> what we display on the first position, since I've kept the current > > >>>>> page/event grouping that is currently implemented. The decision > > depends > > >>>> on > > >>>>> how everyone is using the wiki: are they more interested in > activity > > >>>> being > > >>>>> done on the wiki or who actually did that activity? > > >>>> > > >>>> Both are needed and it depends on the usage I guess. My feeling is > > that > > >>>> humans are good at relationships in a group and a picture speaks > more > > >> than > > >>>> a generic icon for an app. You know who you work with, you know > people > > >> you > > >>>> like, you know who you consider is a stranger, etc and you’ll want > to > > >> check > > >>>> the diff and dive further based on that. The fact that the avatar is > > >> shown > > >>>> prominently will help that. > > >>>> > > >>>> Thanks > > >>>> -Vincent > > >>>> > > >>>>> I like to see who did what, but if the Notifications implementation > > >> will > > >>>>> always group users and we will get the Group icon, than this might > > not > > >> be > > >>>>> very nice. > > >>>>> > > >>>>> Thanks, > > >>>>> Caty > > >>>>> > > >>>>> > > >>>>> > > >>>>>> Thanks > > >>>>>> -Vincent > > >>>>>> > > >>>>>> > > >>>>>>> On 27 Oct 2017, at 17:31, Ecaterina Moraru (Valica) < > > >> [email protected] > > >>>>> > > >>>>>> wrote: > > >>>>>>> > > >>>>>>> Hi, > > >>>>>>> > > >>>>>>> So these are some more iterations for the notifications layout > > >>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ > > >>>>>> NotificationsImprovements9xTypes > > >>>>>>> > > >>>>>>> I've played with User centered vs. Event centered and variants > for > > >>>>>>> displaying the avatars, user names and event names. > > >>>>>>> > > >>>>>>> Let me know what version you prefer. Also you can fork the > > prototypes > > >>>> if > > >>>>>>> you want to make some small changes. > > >>>>>>> > > >>>>>>> Thanks, > > >>>>>>> Caty > > >>>>>>> > > >>>>>>> On Tue, Oct 24, 2017 at 12:47 PM, Vincent Massol < > > [email protected] > > >>> > > >>>>>> wrote: > > >>>>>>> > > >>>>>>>> > > >>>>>>>>> On 24 Oct 2017, at 11:24, Guillaume Delhumeau < > > >>>>>>>> [email protected]> wrote: > > >>>>>>>>> > > >>>>>>>>> Hello > > >>>>>>>>> > > >>>>>>>>> 2017-10-24 11:12 GMT+02:00 Vincent Massol <[email protected] > >: > > >>>>>>>>> > > >>>>>>>>>> Hi Guillaume, > > >>>>>>>>>> > > >>>>>>>>>>> On 24 Oct 2017, at 10:58, Guillaume Delhumeau < > > >>>>>>>>>> [email protected]> wrote: > > >>>>>>>>>>> > > >>>>>>>>>>> Any news on this? I'd like to implement this quickly because > > 9.10 > > >>>> is > > >>>>>>>>>> coming > > >>>>>>>>>>> :) > > >>>>>>>>>> > > >>>>>>>>>> This the current status: > > >>>>>>>>>> * Caty proposed some improved layout for displaying > > notifications > > >>>>>>>>>> * I commented about the need to display event + type, and > about > > >> the > > >>>>>> need > > >>>>>>>>>> to have a link to see the diff. I also mentioned that we need > to > > >>>> work > > >>>>>> on > > >>>>>>>>>> the mail template display > > >>>>>>>>>> * Caty replied and updated her proposal to take into account > > those > > >>>>>>>>>> comments. > > >>>>>>>>>> * I kind of like Caty’s proposal focused on the user. We want > to > > >>>> favor > > >>>>>>>>>> contributions and I think it helps. It also makes the UI more > > >>>>>> appealing > > >>>>>>>>>> visually. > > >>>>>>>>>> * You mentioned that you’d prefer a proposal more focused on > the > > >>>> event > > >>>>>>>>>> rather than the user > > >>>>>>>>>> * Thomas agrees with you > > >>>>>>>>>> * Edy mentioned some extra points > > >>>>>>>>>> > > >>>>>>>>> > > >>>>>>>>> I have also mentioned that the diff we propose is too technical > > for > > >>>>>> many > > >>>>>>>>> users. > > >>>>>>>> > > >>>>>>>> Yes and we have 4 solutions: > > >>>>>>>> > > >>>>>>>> * Solution 1: make it simpler to understand for everyone > > >>>>>>>> * Solution 2: have a wiki admin UI level option to select > whether > > to > > >>>>>>>> include diff or not in the default template + user-level profile > > UI > > >>>>>> option > > >>>>>>>> (ie. per user) > > >>>>>>>> * Solution 3: have a singe button in the mail, that, when > clicked, > > >>>>>>>> displays the diff (which is hidden by default) > > >>>>>>>> * Solution 4: implement 2 mail templates (one for simple users > and > > >> one > > >>>>>> for > > >>>>>>>> advanced users) and let the users choose in their profile which > > one > > >>>> they > > >>>>>>>> want to receive + have a wiki admin UI level option to decide > > which > > >> is > > >>>>>> the > > >>>>>>>> default when not overridden by the user. > > >>>>>>>> > > >>>>>>>> Thanks > > >>>>>>>> -Vincent > > >>>>>>>> > > >>>>>>>>> > > >>>>>>>>>> So I guess we need to decide about whether we show the avatar > as > > >> in > > >>>>>>>> Caty’s > > >>>>>>>>>> proposal or not, right? Is that what you’re asking about > > >> Guillaume? > > >>>>>>>>>> > > >>>>>>>>>> On my side, I don’t see the issue in displaying the user > avatar > > >>>> large > > >>>>>> vs > > >>>>>>>>>> small. The events are still ordered by page events. > > >>>>>>>>>> > > >>>>>>>>>> Thanks > > >>>>>>>>>> -Vincent > > >>>>>>>>>> > > >>>>>>>>> > > >>>>>>>>> Thanks > > >>>>>>>>> > > >>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>>> 2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < > > >>>>>>>>>>> [email protected]>: > > >>>>>>>>>>> > > >>>>>>>>>>>> Note that you have a mail template for the notifications > too. > > >> It's > > >>>>>>>>>>>> https://github.com/xwiki/xwiki-platform/blob/ > > >>>>>>>>>>>> 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- > > >>>>>>>>>>>> core/xwiki-platform-notifications/xwiki-platform- > > >>>>>>>>>>>> notifications-ui/src/main/resources/XWiki/Notifications/ > > >>>>>>>>>>>> MailTemplate.xml#L23 but it's not documented yet. > > >>>>>>>>>>>> > > >>>>>>>>>>>> This mail template allows you to customize the header and > the > > >>>> footer > > >>>>>>>> of > > >>>>>>>>>>>> the email, but not the actual content. > > >>>>>>>>>>>> > > >>>>>>>>>>>> To be precise, each *event type* can have its own template > or > > >>>>>> failback > > >>>>>>>>>> to > > >>>>>>>>>>>> the default one (https://github.com/xwiki/ > > xwiki-platform/blob/ > > >>>>>>>>>>>> acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- > > >>>>>>>>>>>> core/xwiki-platform-web/src/main/webapp/templates/ > > >>>>>>>>>>>> notification/email/default.html.vm) > > >>>>>>>>>>>> > > >>>>>>>>>>>> So it's a template *per event type* and it's not linked to > any > > >>>> user > > >>>>>>>>>>>> choice. But we could add some options in the default > template > > >> for > > >>>>>>>>>> example. > > >>>>>>>>>>>> > > >>>>>>>>>>>> 2017-10-17 16:23 GMT+02:00 Vincent Massol < > [email protected] > > >: > > >>>>>>>>>>>> > > >>>>>>>>>>>>> Hi Guillaume, > > >>>>>>>>>>>>> > > >>>>>>>>>>>>>> On 17 Oct 2017, at 07:16, Guillaume Delhumeau < > > >>>>>>>>>>>>> [email protected]> wrote: > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> Some ideas. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> I have feedback about the fact the diff is way too > technical > > >> for > > >>>>>>>>>> users. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> Example: "What does it means???" > > >> https://img15.hostingpics.net/ > > >>>>>>>>>>>>>> pics/670307example1.png > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> So we could hide this in a "technical details" link. > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> That’s one option but there’s another which is to provide > the > > >>>>>> ability > > >>>>>>>>>> to > > >>>>>>>>>>>>> choose which mail template to use in the Admin and provide > > >>>> several > > >>>>>>>>>>>>> templates for different needs. > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> For example for the xwiki.org watchlist we absolutely need > > to > > >> be > > >>>>>>>> able > > >>>>>>>>>> to > > >>>>>>>>>>>>> see the diffs without clicking a “technical details” link > for > > >>>> each > > >>>>>>>>>>>>> notification. It could be ok if there’s a single “technical > > >>>>>> details” > > >>>>>>>>>> link > > >>>>>>>>>>>>> for ALL notifications that shows all diffs at once. > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> Thanks > > >>>>>>>>>>>>> -Vincent > > >>>>>>>>>>>>> > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> The "details" link could be replaced by a "more" link, > with > > a > > >>>> very > > >>>>>>>>>>>>>> simplified diff (the complete diff would go the the > > technical > > >>>>>>>> details > > >>>>>>>>>>>>> view). > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> In the body of the event, in addition with the title of > the > > >>>>>>>> document, > > >>>>>>>>>> we > > >>>>>>>>>>>>>> could add some extracts of the diff. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> Example taken on gmail: > > >>>>>>>>>>>>>> https://img15.hostingpics.net/pics/763456example2.png > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> I hope it helps, > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> Thanks > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> 2017-10-12 15:38 GMT+02:00 Vincent Massol < > > [email protected] > > >>> : > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> Looks nice. Does it work in all mail clients that support > > >> HTML? > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> I'd like an option to show the details for all events as > > >>>>>> otherwise > > >>>>>>>>>> it's > > >>>>>>>>>>>>>>> too painful to have to open all one by one (for the use > > case > > >>>> when > > >>>>>>>> you > > >>>>>>>>>>>>> want > > >>>>>>>>>>>>>>> to check everything). > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> Same as Guillaume: not all events are page-related > events. > > So > > >>>> we > > >>>>>>>> need > > >>>>>>>>>>>>> to > > >>>>>>>>>>>>>>> handle those too. > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> Thanks! > > >>>>>>>>>>>>>>> -Vincent > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < > > >>>>>>>>>>>>>>> [email protected]> wrote: > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> First of all, it looks very nice. > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> Now, you said the events are displayed like in the > > >>>>>> notifications, > > >>>>>>>>>> but > > >>>>>>>>>>>>> in > > >>>>>>>>>>>>>>>> the notifications they are ordered by dates, not by > pages. > > >>>> Does > > >>>>>>>> your > > >>>>>>>>>>>>>>>> proposal imply to change the ordering? What about events > > >> that > > >>>> do > > >>>>>>>> not > > >>>>>>>>>>>>>>>> concern any page (like: "a new wiki has been created" or > > "a > > >>>> new > > >>>>>>>>>> XWiki > > >>>>>>>>>>>>>>>> version is available")? We don't have such events for > now > > >> but > > >>>> we > > >>>>>>>>>> plan > > >>>>>>>>>>>>> to > > >>>>>>>>>>>>>>>> have some soon. We could display them last for example. > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> Nice CSS expand! > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> Thanks you, > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < > > >>>>>>>>>>>>> [email protected] > > >>>>>>>>>>>>>>>> : > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> This is a proposal for the Notifications mail: > > >>>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ > > >>>>>>>>>>>>>>>>> NotificationsImprovements9xEmail > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> I've continued with the 'user' avatar focused proposal, > > >> since > > >>>>>>>> I've > > >>>>>>>>>>>>>>>>> currently focused on the email template. If we drop the > > >> user > > >>>>>>>> avatar > > >>>>>>>>>>>>>>> (since > > >>>>>>>>>>>>>>>>> we group multiple users) then we can have the event/app > > >> icon > > >>>>>>>>>> instead > > >>>>>>>>>>>>> of > > >>>>>>>>>>>>>>> the > > >>>>>>>>>>>>>>>>> avatar. > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> What I want to have feedback on is the email layout, > > >>>>>>>> functionality > > >>>>>>>>>>>>> (tree > > >>>>>>>>>>>>>>>>> navigation, details expanding) and styling. > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> You can play with the Prototype > > >>>>>>>>>>>>>>>>> http://jsfiddle.net/risherry/cj25759w/embedded/#Result > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> If we were to translate to the mail template, there are > > >> still > > >>>>>>>> some > > >>>>>>>>>>>>>>> things > > >>>>>>>>>>>>>>>>> to be tested (like translating the CSS selectors into > > >> inline, > > >>>>>>>>>> decide > > >>>>>>>>>>>>>>> what > > >>>>>>>>>>>>>>>>> email clients we support, etc.) > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> Let me know, > > >>>>>>>>>>>>>>>>> Caty > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < > > >>>>>>>>>>>>>>>>> [email protected]> wrote: > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < > > >>>>>>>>>>>>>>> [email protected] > > >>>>>>>>>>>>>>>>>> : > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau > < > > >>>>>>>>>>>>>>>>>>> [email protected]> wrote: > > >>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol < > > >>>>>> [email protected] > > >>>>>>>>> : > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol < > > >>>>>> [email protected] > > >>>>>>>>> > > >>>>>>>>>>>>>>>>>> wrote: > > >>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol < > > >>>>>>>> [email protected]> > > >>>>>>>>>>>>>>>>>> wrote: > > >>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>> Another feedback/questions: > > >>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>> * Is the avatar icon clickable and leading to the > > >> user > > >>>>>>>>>> profile? > > >>>>>>>>>>>>>>>>>>>>>>> * We need a way to link directly to the diff, at > > >> least > > >>>>>> for > > >>>>>>>>>> page > > >>>>>>>>>>>>>>>>>>> events > > >>>>>>>>>>>>>>>>>>>>> so that the user can see what was modified (as we > > have > > >>>>>>>>>> currently > > >>>>>>>>>>>>> in > > >>>>>>>>>>>>>>>>>> the > > >>>>>>>>>>>>>>>>>>>> AS) > > >>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>> * Maybe “2 hours ago” is not precise enough. In > your > > >>>>>>>> example I > > >>>>>>>>>>>>>>>>> see > > >>>>>>>>>>>>>>>>>> I > > >>>>>>>>>>>>>>>>>>>>> created and modified the Roadmap page but they both > > say > > >>>> “2 > > >>>>>>>>>> hours > > >>>>>>>>>>>>>>>>>> ago”. > > >>>>>>>>>>>>>>>>>>>>> Shouldn’t I be able to see how far away both events > > >> were > > >>>>>>>> done? > > >>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>> My understanding is that events are grouped by > > app+type > > >>>> but > > >>>>>>>> not > > >>>>>>>>>>>>> by > > >>>>>>>>>>>>>>>>>>> entity > > >>>>>>>>>>>>>>>>>>>>> anymore (for page events) and thus you can have 3 > > >> events > > >>>>>>>>>>>>> displayed > > >>>>>>>>>>>>>>>>>> for > > >>>>>>>>>>>>>>>>>>>> the > > >>>>>>>>>>>>>>>>>>>>> same page, f.ex: Creation, Modification, Deletion. > > >>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> And you could also have different users grouped in > the > > >>>> same > > >>>>>>>>>>>>> composite > > >>>>>>>>>>>>>>>>>>>> event. So when you display the details, it would be > > nice > > >>>> to > > >>>>>>>> show > > >>>>>>>>>>>>>>>>> which > > >>>>>>>>>>>>>>>>>>> user > > >>>>>>>>>>>>>>>>>>>> made each event, and I see you have removed this > info. > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> The focus of this proposal is on user, compared to > the > > >> old > > >>>>>> one, > > >>>>>>>>>>>>> when > > >>>>>>>>>>>>>>> it > > >>>>>>>>>>>>>>>>>> was > > >>>>>>>>>>>>>>>>>>> on the app/doc. > > >>>>>>>>>>>>>>>>>>> Close to what we have on Facebool. So it didn't made > > >> sense > > >>>>>> that > > >>>>>>>>>> we > > >>>>>>>>>>>>> say > > >>>>>>>>>>>>>>>>>> that > > >>>>>>>>>>>>>>>>>>> a page has been edited by vmassol, and that the > details > > >>>>>>>> showcase > > >>>>>>>>>>>>> that > > >>>>>>>>>>>>>>>>>>> multiple user actually did the edit. > > >>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>> In Facebook, you have it actually: > > >>>>>>>>>>>>>>>>>> https://pasteboard.co/GOioRAT.png > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>> On XWiki, we have the following (already implemented): > > >>>>>>>>>>>>>>>>>> https://pasteboard.co/GOiqgYf.png > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>> Thanks, > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>> Thanks > > >>>>>>>>>>>>>>>>>>>>> -Vincent > > >>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>> Thanks > > >>>>>>>>>>>>>>>>>>>>>> -Vincent > > >>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>> Thanks > > >>>>>>>>>>>>>>>>>>>>>>> -Vincent > > >>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol < > > >>>>>>>> [email protected] > > >>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> wrote: > > >>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru > > (Valica) > > >> < > > >>>>>>>>>>>>>>>>>>>> [email protected]> > > >>>>>>>>>>>>>>>>>>>>> wrote: > > >>>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>>> Event Type: BlogPostPublishedEvent > > >>>>>>>>>>>>>>>>>>>>>>>>> from > > >>>>>>>>>>>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/ > bin/view/Proposal/ > > >>>>>>>>>>>>>>>>>>>>> NotificationsImprovements9x#HEventTypes > > >>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>> ok thanks, had missed this since I was reading > > from > > >>>> top > > >>>>>> to > > >>>>>>>>>>>>>>>>> bottom > > >>>>>>>>>>>>>>>>>>> and > > >>>>>>>>>>>>>>>>>>>>> stopped at the overview :) > > >>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>> However I don’t think it scales since it means > one > > >>>>>> unique > > >>>>>>>>>> icon > > >>>>>>>>>>>>>>>>>> per > > >>>>>>>>>>>>>>>>>>>>> combination of app type + event type. > > >>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>> What would scale better is two icons: one for > the > > >> app > > >>>>>> type > > >>>>>>>>>> and > > >>>>>>>>>>>>>>>>>> one > > >>>>>>>>>>>>>>>>>>>> for > > >>>>>>>>>>>>>>>>>>>>> the event type. > > >>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>> For example imagine that the Blog app had the > > >>>> following > > >>>>>>>>>>>>> events: > > >>>>>>>>>>>>>>>>>>>>>>>> * When a blog post is published > > >>>>>>>>>>>>>>>>>>>>>>>> * When a blog post is created > > >>>>>>>>>>>>>>>>>>>>>>>> * When a blog post is removed > > >>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>> You wouldn’t be able to use the RSS icon to > > >> represent > > >>>>>> the > > >>>>>>>> 3 > > >>>>>>>>>>>>>>>>>> events. > > >>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>> BTW the RSS icon isn’t necessarily > representative > > of > > >>>> the > > >>>>>>>>>> Blog > > >>>>>>>>>>>>>>>>>> app. > > >>>>>>>>>>>>>>>>>>> A > > >>>>>>>>>>>>>>>>>>>>> lot of apps can have a RSS feed. > > >>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>> That’s the main remark I have: it’s going to be > > >> harder > > >>>>>> and > > >>>>>>>>>>>>>>>>> harder > > >>>>>>>>>>>>>>>>>>> to > > >>>>>>>>>>>>>>>>>>>>> find unique icons as we had more events to apps, > > >>>> especially > > >>>>>>>> if > > >>>>>>>>>>>>>>>>>> there’s > > >>>>>>>>>>>>>>>>>>>> only > > >>>>>>>>>>>>>>>>>>>>> 1 icon that is supposed to combine both app type + > > >> event > > >>>>>>>> type. > > >>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>> WDYT? > > >>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>> Thanks > > >>>>>>>>>>>>>>>>>>>>>>>> -Vincent > > >>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>>> Thanks, > > >>>>>>>>>>>>>>>>>>>>>>>>> Caty > > >>>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol > < > > >>>>>>>>>>>>>>>>>>> [email protected]> > > >>>>>>>>>>>>>>>>>>>>> wrote: > > >>>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>>>> Hi Caty, > > >>>>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru > > >> (Valica) > > >>>> < > > >>>>>>>>>>>>>>>>>>>>> [email protected]> > > >>>>>>>>>>>>>>>>>>>>>>>>>> wrote: > > >>>>>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>>>>> Hi, > > >>>>>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>>>>> I've created some improvements suggestions > for > > >> our > > >>>>>>>>>>>>>>>>>> Notifications > > >>>>>>>>>>>>>>>>>>>>> UI, see > > >>>>>>>>>>>>>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/ > > bin/view/Proposal/ > > >>>>>>>>>>>>>>>>>>>>>>>>>> NotificationsImprovements9x > > >>>>>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>>>>> Let me know what you think. > > >>>>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>>>> Re the overview, I don’t see where you mention > > the > > >>>>>> app? > > >>>>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>>>> For example, could you show how a new Blog > post > > >>>> would > > >>>>>> be > > >>>>>>>>>>>>>>>>>>> displayed > > >>>>>>>>>>>>>>>>>>>>> and you > > >>>>>>>>>>>>>>>>>>>>>>>>>> differentiate that for example from a Page > > >> creation > > >>>> or > > >>>>>>>>>>>>>>>>>>>> modification? > > >>>>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>>>> Thanks > > >>>>>>>>>>>>>>>>>>>>>>>>>> -Vincent > > >>>>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>>>>> Thanks, > > >>>>>>>>>>>>>>>>>>>>>>>>>>> Caty > > >>>>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>>> -- > > >>>>>>>>>>>>>>>>>>>> Guillaume Delhumeau ([email protected]) > > >>>>>>>>>>>>>>>>>>>> Research & Development Engineer at XWiki SAS > > >>>>>>>>>>>>>>>>>>>> Committer on the XWiki.org project > > >>>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>>> -- > > >>>>>>>>>>>>>>>>>> Guillaume Delhumeau ([email protected]) > > >>>>>>>>>>>>>>>>>> Research & Development Engineer at XWiki SAS > > >>>>>>>>>>>>>>>>>> Committer on the XWiki.org project > > >>>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>>> -- > > >>>>>>>>>>>>>>>> Guillaume Delhumeau ([email protected]) > > >>>>>>>>>>>>>>>> Research & Development Engineer at XWiki SAS > > >>>>>>>>>>>>>>>> Committer on the XWiki.org project > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> -- > > >>>>>>>>>>>>>> Guillaume Delhumeau ([email protected]) > > >>>>>>>>>>>>>> Research & Development Engineer at XWiki SAS > > >>>>>>>>>>>>>> Committer on the XWiki.org project > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>>>>> -- > > >>>>>>>>>>>> Guillaume Delhumeau ([email protected]) > > >>>>>>>>>>>> Research & Development Engineer at XWiki SAS > > >>>>>>>>>>>> Committer on the XWiki.org project > > >>>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>>> -- > > >>>>>>>>>>> Guillaume Delhumeau ([email protected]) > > >>>>>>>>>>> Research & Development Engineer at XWiki SAS > > >>>>>>>>>>> Committer on the XWiki.org project > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>> > > >>>>>>>>> > > >>>>>>>>> -- > > >>>>>>>>> Guillaume Delhumeau ([email protected]) > > >>>>>>>>> Research & Development Engineer at XWiki SAS > > >>>>>>>>> Committer on the XWiki.org project > > >> > > >> > > > > > > > -- > Guillaume Delhumeau ([email protected]) > Research & Development Engineer at XWiki SAS > Committer on the XWiki.org project >
