On 11/8/23 07:25, Robert Varga wrote:
On 08/11/2023 14.53, Andrew Grimberg wrote:Greetings Robert, On 11/7/23 15:47, Robert Varga wrote:[snip]And I also have an issue to report: +2/Submit Gerrit shortcut is broken.git.opendaylight.org/gerrit/c/netconf/+/108831 is fully verified and I do not have a '+2' button in top right corner.That means I have to go through: - "Reply" - "+2" - "Send" This hurts A LOT on this side of the pond.Are these self-reviews? I only see that with self-reviews and it's a UI change in Gerrit itself that I have not found how to bring back. The Gerrit devs have basically hidden self-review on purpose to strongly discourage it as it is not a best practice.Yes, these are self reviews, there are a number of projects where we are down to doing these.It does seem to be related to the GHA change, as this earlier this week and we are still running the same Gerrit version (3.7.2)...
The only change that was made to Gerrit itself was to do away with the deprecated prolog rules and deprecated submission rights blocks to switch to the new submit requirements system. When we had upgraded the LF Gerrit to 3.7.2 that option went away for everyone doing self-review. When we switched to using submit requirements it didn't change the functionality.
Why you would have still had the option in the I don't know. You can (sort of) get the same functionality by hovering over the Code-Review label in the Submit Requirements section. I believe you should see the button there. If so, that will save you a few clicks.
-Andy- -- Andrew J Grimberg Senior Manager, Release Engineering The Linux Foundation NOTICE: The Linux Foundation supports their employees with flexible work hours. If you recieve mail from me outside of standard business hours please be aware that I do not expect a response until the next standard business day. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#9031): https://lists.opendaylight.org/g/Discuss/message/9031 Mute This Topic: https://lists.opendaylight.org/mt/102443749/21656 Group Owner: discuss+ow...@lists.opendaylight.org Unsubscribe: https://lists.opendaylight.org/g/Discuss/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
OpenPGP_signature.asc
Description: OpenPGP digital signature
