On Thu, 2010-09-30 at 01:32 +0400, Ivan Sagalaev wrote: > My suggestion is about this unfortunate ticket status -- 'Accepted'. > This now works as a sort of a dusty shelf: when anyone of the core team > looks at the patch and decides that there's nothing wrong with it he > puts it on that shelf where the ticket has all the chances to lie for > months or even years. And if the author of the patch tries from time to > time pitching it to get it into trunk he can easily fall into all sorts > of "not-a-good-times": conferences, feature freezes, hot discussions on > other topics etc. > > My proposal is simple: 'Accepted' status shouldn't exist. If the patch > is good it should be committed right away. If it's not there have to be > an explanation why it needs improvement or why it's going to be > wontfixed. Simple waiting doesn't really improve quality of the patch. > > What do you think?
This doesn't account for these facts: 1) Accepted != Ready for checkin. 2) A lot of triage is done by people without commit access. Sometimes a ticket stays at 'Accepted' for a long time because it doesn't actually have anyone motivated enough to write even a patch, or tests etc, which means that it is de-facto low priority, and we shouldn't feel guilty about this kind. The ones in the 'Ready for checkin' queue are the ones that deserve to be checked in, and it currently has only 35 in it, compared to 1226 in 'Accepted'. However, there are many 'Accepted' tickets which actually ought to be in 'Ready for checkin', or need some feedback to say what should be done to move them on. This is not something that can only be done by committers, but how to get help with this massive task is still a big problem. It's quite possible for someone using Django to submit a completely valid bug report, with a good patch and tests etc., and for it not to get reviewed because no-one else in the community cares about that particular bug, and I for one don't know what to do about that. The core team do agree that the "it's not a good time" response has been an unhelpful sticking point, and we probably need to make it easier for people to discuss things at any point in time. Luke -- "Defeat: For every winner, there are dozens of losers. Odds are you're one of them." (despair.com) Luke Plant || http://lukeplant.me.uk/ -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
