On Sat, 2003-06-21 at 14:14, Andreas Stenglein wrote:
>
> [...] some comments where I dont know what to do.
I'll try to address some of them:
> + if( (sPriv->drmMinor < 3) || (getenv( "RADEON_NO_3RD_TMU")) ) /*
> question: is the check for drmMinor necessary? */
> + ctx->Const.MaxTextureUnits = 2;
> + else
> + ctx->Const.MaxTextureUnits = RADEON_MAX_TEXTURE_UNITS; /* 3 */
Does the 3rd TMU require any DRM support not present before that minor
version?
> + /* question: shouldn't the following be controlled by the
> kernelmodule */
> + /* and/or Xserver-configuration if it can crash the card? */
> else if (getenv("RADEON_TCL_FORCE_ENABLE")) {
> fprintf(stderr, "Enabling TCL support... this will probably
> crash\n");
> fprintf(stderr, " your card if it isn't capable of
> TCL!\n");
Why? :)
I do wonder if trying to enable HW TCL makes sense though, there was a
bit of confusion about TCL support on the various chips at the time.
Maybe we can clean this up with the new config infrastructure.
> + init_rgba_st_st_st();
> + init_rgba_spec_st_st_st();
> + init_st_st_st_n();
> + init_rgpa_spec_st_st_st_n(); /* question: don't know what "rgpa"
> is, just copied and modified.. */
> + init_rgba_stq_stq_stq();
> + init_w_rgpa_spec_stq_stq_stq_n();
Looks like a typo?
--
Earthling Michel Dänzer \ Debian (powerpc), XFree86 and DRI developer
Software libre enthusiast \ http://svcs.affero.net/rm.php?r=daenzer
-------------------------------------------------------
This SF.Net email is sponsored by: INetU
Attention Web Developers & Consultants: Become An INetU Hosting Partner.
Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission!
INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel
