On Friday, October 17, 2008 7:10 pm Eric Anholt wrote: > On Fri, 2008-10-17 at 15:43 -0700, Linus Torvalds wrote: > > On Fri, 17 Oct 2008, Dave Airlie wrote: > > So what's the excuse _this_ time for adding all these stupid warnings to > > my build log? Did nobody test this? > > > > drivers/gpu/drm/drm_proc.c: In function ‘drm_gem_one_name_info’: > > drivers/gpu/drm/drm_proc.c:525: warning: format ‘%d’ expects type > > ‘int’, but argument 3 has type ‘size_t’ drivers/gpu/drm/drm_proc.c:533: > > warning: format ‘%9d’ expects type ‘int’, but argument 4 has type > > ‘size_t’ drivers/gpu/drm/i915/i915_gem.c: In function > > ‘i915_gem_gtt_pwrite’: drivers/gpu/drm/i915/i915_gem.c:184: warning: > > unused variable ‘vaddr_atomic’ > > Yeah, none of us are on x86-64, so we missed those warnings in testing.
Actually, I'm on x86_64 pretty much exclusively and saw these warnings last week. But I didn't send a fix (yet); sorry. That said, this code was far from untested, even though it did contain a few compile warnings, so I think Linus's complaint about UNTESTED CRAP was at least half wrong. -- Jesse Barnes, Intel Open Source Technology Center ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
