Matthieu Moy <[EMAIL PROTECTED]> writes: > Stephen Leake <[EMAIL PROTECTED]> writes: > > I'd rather leave the partner buffer to "nil", or even keep the source > file, but fix this > >> However, other code assumes dvc-partner-buffer for a dvc-log-edit >> buffer is the dvc-status or dvc-diff buffer associated with the commit >> in progress. > > with s/assumes/should not assume/
Hmm. I don't see what use the dvc-partner-buffer variable is, if we can't assume we know what it's supposed to be. The doc string for dvc-partner-buffer says: "DVC Partner buffer; stores diff buffer for log-edit, etc. Must be local to each buffer." bzr-log-edit-commit, xmtn-dvc-log-edit use it to resolve relative file names; it must be a buffer which has the correct default-directory. dvc-dvc-files-to-commit, xgit-dvc-log-edit-done, xhg-dvc-log-edit-done, xmtn-dvc-log-edit-done use it to get dvc-current-file-list; it must be the diff or status buffer. That's all the uses of dvc-partner-buffer in DVC, other than simple navigation. What was the original intent of dvc-partner-buffer? If it was just navigation, would being able to navigate between an arbitrary source buffer and the log-edit buffer be useful? -- -- Stephe _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
