Stephen Leake <[EMAIL PROTECTED]> writes: > Then all back-ends would commit all files (or possibly no files), > rather than the correct list of files, if the user had marked some. > That's wrong.
It doesn't change the existing behavior: You can already do something like Run dvc-status Run dvc-diff Run dvc-log-edit <-- partner buffer is diff. switch to dvc-status mark files switch back to dvc-log-edit without running log-edit commit. You mark files at some point in time, but you don't commit them individually. Individual files commit is always done with respect to the buffer you're comming from. > If we do 1, the behavior of dvc-pop-to-partner-buffer from a log-edit > buffer will be more predictable. I find it to be the opposite. If dvc-add-log-entry sets the partner buffer, I'd *never* expect it to point to a buffer I'm not comming from. If the partner-buffer is disturbing you, don't set it and leave it to nil, but please, don't set it to an arbitrary buffer. With your proposal, if I have a diff-buffer with marked files which I totally forgot about, I'd make a selected files commit without even noticing. -- Matthieu _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
