I've just run across a problem with dvc-add-log-entry. If it is invoked _before_ dvc-log-edit, it creates a dvc-log-edit buffer with dvc-partner-buffer set to the file it was invoked from. However, other code assumes dvc-partner-buffer for a dvc-log-edit buffer is the dvc-status or dvc-diff buffer associated with the commit in progress.
Invoking dvc-log-edit this way also loses dvc-buffer-current-active-dvc; if I'm working with bzr, it runs xmtn-dvc-log-edit. One way to fix this is to abort dvc-add-log-entry if a dvc-log-edit buffer is not found. Better would be to prompt for a dvc-status or dvc-diff buffer to use as the partner; if there is only one such, just use it. Does that make sense? -- -- Stephe _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
