Stephen Leake <[EMAIL PROTECTED]> writes:
> bzr-log-edit-commit, xmtn-dvc-log-edit use it to resolve relative file
> names; it must be a buffer which has the correct default-directory.
Hmm, not just "resolve relative file names", but "get the list of
marked files, and resolve relative file names in this context":
(when (buffer-live-p dvc-partner-buffer)
(with-current-buffer dvc-partner-buffer
(mapcar #'dvc-uniquify-file-name
(dvc-current-file-list 'nil-if-none-marked)))))
> dvc-dvc-files-to-commit, xgit-dvc-log-edit-done,
> xhg-dvc-log-edit-done, xmtn-dvc-log-edit-done use it to get
> dvc-current-file-list; it must be the diff or status buffer.
>
> That's all the uses of dvc-partner-buffer in DVC, other than simple
> navigation.
IIRC, we had dvc-partner-buffer for navigation, like
`dvc-buffer-pop-to-partner-buffer', and anothe mechanism for log-edit
to know which buffer it was comming from, to get the file list in case
of a partial commit. Later, we merged both concepts.
> If it was just navigation, would being able to navigate between an
> arbitrary source buffer and the log-edit buffer be useful?
I think it would, hence my proposal. For the case of bzr (see above),
I believe modifying `dvc-current-file-list' to return nil when not in
a diff-mode buffer would do it.
--
Matthieu
_______________________________________________
Dvc-dev mailing list
[email protected]
https://mail.gna.org/listinfo/dvc-dev
