Hi Michael! > I expected dvc-apply to act roughly the same as `apply', but it instead > acts like funcall. We should either change its name to dvc-funcall, or > change its behavior so that it actually acts like `apply' -- both > approaches would involve modifying all callers.
I would prefer renaming to dvc-funcall To summarize the functionality of apply/funcall: (apply '+ '(4 5)) (funcall '+ 4 5) Here is how we use dvc-apply: (dvc-apply "dvc-diff" base-rev path dont-switch) So using dvc-funcall matches the above pattern a bit better. The remaining question is if we should replace the string by a symbol also, like this: (dvc-funcall 'dvc-diff base-rev path dont-switch) Stefan. _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
