Matthieu Moy <[EMAIL PROTECTED]> writes: > Stefan Reichör <[EMAIL PROTECTED]> writes: > >> Hi Michael! >> >>> I expected dvc-apply to act roughly the same as `apply', but it instead >>> acts like funcall. We should either change its name to dvc-funcall, or >>> change its behavior so that it actually acts like `apply' -- both >>> approaches would involve modifying all callers. >> >> I would prefer renaming to dvc-funcall > > True. > > We can also add a dvc-apply if needed. > >> (dvc-funcall 'dvc-diff base-rev path dont-switch) > > Well, the first thing dvc-funcall will do with the symbol is to > convert it into a string, and the use of a symbol makes me think I'm > actually going to do something with the object called 'dvc-diff > (either function or variable), which isn't true.
This reasons are very valid. We should keep the string as first parameter. > So, keeping the string is IMO more intuitive, and probably slightly > more efficient. Stefan. _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
