Michael Olson <[EMAIL PROTECTED]> writes: > Matthieu Moy <[EMAIL PROTECTED]> writes: > >>> (dvc-funcall 'dvc-diff base-rev path dont-switch) >> >> Well, the first thing dvc-funcall will do with the symbol is to >> convert it into a string, and the use of a symbol makes me think I'm >> actually going to do something with the object called 'dvc-diff >> (either function or variable), which isn't true. >> >> So, keeping the string is IMO more intuitive, and probably slightly >> more efficient. > > I completely disagree with the "intuitive" part. You will never > `funcall' a string. Just a lambda form or a symbol. So we should make > `dvc-funcall' take a symbol.
If I read (defun foo (...) ...) (dvc-funcall 'foo ...) I really expect the second to refer to the first (and this kind of things do happen, when dvc-foo is a dispatching function, and dvc-dvc-foo is a possible target for the dispatch). -- Matthieu _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
