Matthieu Moy <[EMAIL PROTECTED]> writes: >> (dvc-funcall 'dvc-diff base-rev path dont-switch) > > Well, the first thing dvc-funcall will do with the symbol is to > convert it into a string, and the use of a symbol makes me think I'm > actually going to do something with the object called 'dvc-diff > (either function or variable), which isn't true. > > So, keeping the string is IMO more intuitive, and probably slightly > more efficient.
I completely disagree with the "intuitive" part. You will never
`funcall' a string. Just a lambda form or a symbol. So we should make
`dvc-funcall' take a symbol.
--
Michael Olson -- FSF Associate Member #652 |
http://mwolson.org/ -- Jabber: mwolson_at_hcoop.net | /` |\ | | |
Sysadmin -- Hobbies: Lisp, GP2X, HCoop | |_] | \| |_|
Projects: Emacs, Muse, ERC, EMMS, ErBot, DVC, Planner |
pgpINh7e4cH6C.pgp
Description: PGP signature
_______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
