Charles Choi <kickingve...@gmail.com> writes: > Patch v1 (addd8dcd) for Worg org-protocol.org: Remove 3rd Party Applications > header submitted for review. > > > [2. text/x-diff; 0001-org-protocol.org-Remove-3rd-party-applications.patch]... >
Thanks! > Subject: [PATCH] org-protocol.org: Remove 3rd party applications Please add "header" to the subject line of the patch for clarity (we're removing the header, not the apps). I was going to just apply this simple change right away, but it strikes me that it entails some further changes that might as well be done in the same patch. Suggestions: - A more descriptive section header: "Construct Org protocol URL request" doesn't really cover the contents, since the section isn't really about constructing URLs (the schemes are covered elsewhere), and e.g. with Captee you wouldn't need to think about it (I think?). It's about *making* requests to Org protocol from external apps or scripts. E.g. "Make a request with Org protocol"? - An extra item in the bullet list at the beginning of the section to reflect that that third-party apps are incorporated. (The list does refer to "program/script generation", but from context that would be understood more as user scripts, not applications like Acrobat or Opera.) - Perhaps delete the line "Once the URL request has been constructed, it can be sent to Emacs via the scheme handler" or consolidate it with the opening line, e.g.: "Numerous approaches can be used to construct an Org protocol request and send it to Emacs via the scheme handler:". - In any case, add a brief line of bridging text should before the detailed items on "Web browser bookmark", "Captee" etc. begin, e.g. "Specific information on some of the available options follows:". (- It seems slightly strange to have separate items for "Web browser bookmark" and "Opera", but I'm inclined to leave this for now, as we may remove or change the Opera bit in any case.) Yours, Christian
