Charles Choi <kickingve...@gmail.com> writes: > Christian - > > Status update on review of this patch?
Apologies and thanks for the ping! I've let things slide a bit while waiting for the server issue to clear up. Looks good. Niggles: 1. Could you *either* just resubmit with a commit message that finds space to mention the Opera removal in the first line, *or* break out the Opera removal in a separate patch? Thanks. 2. Three small wording changes: > +The scheme handler can be bypassed by direct invocation of > +~emacsclient~. That said, on platforms like macOS that employ > +sandboxing/hardened runtimes for applications, this will lead to > +security restrictions that prevent its usage by 3rd party Suggest changing "lead to" to "run into" (or a better wording if you can think of one; "lead to" is awkward because it reads as if org-protocol use is the cause of the restrictions). > +Listed below describe some approaches to making an Org protocol URL ^^^^^^^^ describe > are > +Users with shell access can issue the URL request via command line > +utility. This utility is platform-dependent. Add "a" after "via" Regards, Christian