Pedro Andres Aranda Gutierrez <paag...@gmail.com> writes:
> I'd like to go on a step-by-step review instead of getting all
> comments in one email (if that is possible).
Sure. I will start from reviewing changes to the manual.
> -Org file. See the docstring for the
> -~org-latex-default-packages-alist~ for loading packages with certain
> -compilers. Also see ~org-latex-bibtex-compiler~ to set the
> -bibliography compiler[fn:48].
> +Org file. In conjunction with the ~org-latex-multi-lang-driver~
> +variable or the ~#+LATEX_MULTI_LANG~ keyword below, it controls the
> +package to support multiple languages and/or scripts in your document.
> +See the docstring for the ~org-latex-default-packages-alist~ for
> +loading packages with certain compilers. Also see
> +~org-latex-bibtex-compiler~ to set the bibliography compiler[fn:48].
This paragraph becomes loaded enough that we may want to split it into
multiple, I think.
> In order to be effective, the =babel= or =polyglossia=
> packages---according to the LaTeX compiler used---must be loaded
I think that this statement is no longer strictly accurate. With
LATEX_MULTI_LANG, babel/polyglossia may be loaded automatically.
I suggest merging description of LANGUAGE and LATEX_MULTI_LANG into one
record, similar to =LATEX_HEADER=, =LATEX_HEADER_EXTRA=.
Also, since we now allow multiple languages to be listed in #+LANGUAGE,
we may need to update the manual when talking about #+LANGUAGE keyword
in other places as well; not just in latex export section.
> The LaTeX package handling multi-lingual features. Possible values
> + are ~"polyglossia"~, ~"babel"~, ~t~ or ~nil~. When it is ~t~, the
> + new font control features are activated. When it is either
Please avoid word "new" and other relative time references in the manual.
> +The LaTeX export backend can handle multiple languages with the LateX
> +packages =babel= or =polyglossia=. It will use the =LANGUAGE= keyword,
> +if present in the document or the value of
> +~org-export-default-language~ to determine the languages used in a
> +document. If this value is a comma-separated list of languages, it
> +will assume the first one to be the main language in the list.
> ...
I suggest making this into a dedicated section.
> The LaTeX templates in =org= may include the =[FONTSPEC]= keyword,
> which acts as a placeholder for font specification code. By default,
> Org mode places the font specification code at the beginning of the
> generated LaTeX output.
When referring to Org mode, use "Org mode", not =org= :)
> # This feature is currently supported for LuaLaTeX and XeLaTex.
> # (c.f. [[#lualatex-fontspec][below]]). An empty string will be
> # generated for PDFLaTeX.
This comment is unnecessary, right?
> #+BEGIN_SRC elisp :results output :exports both
> ("math" :font "TeX Gyre Termes Math")
> #+END_SRC
I suggest providing example snippets that can be copy-pasted
directly. It will make life easier for the users.
> #+BEGIN_SRC latex
> \directlua{
> luaotfload.add_fallback ("fallback_main",{
> "Noto Color Emoji:mode=harf",
> })
> }
> #+END_SRC
What will happen in XeLaTeX?
> *Notes*
I think you can drop "notes"
> - You may use any font name used in the ~\set..font{}~ command by the
> ~fontspec~ package. For example, when using XeLaTeX, you can
> compose Chinese, Japanese or Korean test using the ~xeCJK~ and
> ~xpinyin~ packages. These packages define the ~\\setCKJmainfont{}~,
> ~\\setCJKsansfont{}~ and ~\\setCJKmonofnt{}~ commands. Use the
> ~CJKmain~, ~CJKsans~ and ~CJK mono~ definitions in your documents to
> customise them:
> If you need more features, add then to this list.
*them
> # TODO: Subsection with the font configuration specific to
> # polyglossia.
This is done already, right? So, should be removed.
> The properties you can define are:
>
> 1. =:font=: a string with the system font name. This property is *mandatory*.
> 2. =:variant=: a string for the font variant (e.g. "=sf=", "=tt=", etc.).
May we give a brief description of when these variants mean? For people
unfamiliar with font intricacies.
> 3. =:tag=: a string that will used to define the language name in the
> font family. For example, the language may be ="hindi"= but the
> name for the font family ="devanagari"=. In this case, the latter
> can be indicated with a =:tag=,
Should this be an Org language name? We should refer to the list of
available names somewhere in the manual.
> 4. =:props=: a string for extra properties. The square bracket are not
> needed, because they are added by Org.
We should probably refer again to some polyglossia manual here, to
direct users to other available properties.
> +[fn:49] Emacs will look up the whole directory tree until your =$HOME=
> +directory and load the first directory local variable definition file
> +it finds. You can, for example, set a common definition for all your
> +documents in your =Documents= directory and then create a specific
> +file for projects that deviate from it.
Rather than repeating Emacs manual, just refer to it via info: link.
There are examples how to do it in the Org manual.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
