Hi Ihor, more commits and a doubt:
> >> Also, since we now allow multiple languages to be listed in #+LANGUAGE,
> >> we may need to update the manual when talking about #+LANGUAGE keyword
> >> in other places as well; not just in latex export section.
> You seemingly did not address this comment.
I've gone through the code once again and I think we need to start
looking at places where #+LANGUAGE is used outside the LaTeX exporter.
There we will need to filter out and keep the first language if we
find a comma separated list of languages...
WDYT?
/PA
On Mon, 30 Jun 2025 at 08:41, Pedro Andres Aranda Gutierrez
<paag...@gmail.com> wrote:
>
> Hi
>
> Answers inline,
>
> On Sun, 29 Jun 2025 at 20:03, Ihor Radchenko <yanta...@posteo.net> wrote:
> >
> > Pedro Andres Aranda Gutierrez <paag...@gmail.com> writes:
> >
> > > Pushed reworked doc...
> >
> > Thanks!
> > It would also be helpful if you provided a brief summary of what you did
> > wrt every point I raised in my review message. That would help me and
> > also help you to make sure that you went through every suggestion.
>
> Suggestion taken :-)
>
> > > The LaTeX export backend can use any of these LaTeX engines:
> > > =pdflatex=, =xelatex=, and =lualatex=. These engines compile LaTeX
> > > files with different compilers, packages, and output options. The
> > > LaTeX export backend finds the compiler version to use from
> > > ~org-latex-compiler~ variable or the =#+LATEX_COMPILER= keyword in the
> > > Org file.
> > >
> > > In conjunction with the ~org-latex-multi-lang-driver~ variable or the
> > > ~#+LATEX_MULTI_LANG~ keyword below, it controls the package to support
> > > multiple languages and/or scripts in your document. See the docstring
> > > for the ~org-latex-default-packages-alist~ for loading packages with
> > > certain compilers. Also see ~org-latex-bibtex-compiler~ to set the
> > > bibliography compiler[fn:48].
> >
> > Even though you did split the paragraph, it is IMHO, not yet ideal.
> > When I read the two paragraph one after another I feel confused.
> > When I read the LaTeX section from the beginning, I feel even more
> > confused - what do these paragraphs do in LaTeX/PDF export commands section?
> >
> > Maybe we can simply remove the above paragraphs, moving the information
> > under LaTeX specific export settings?
>
> It was intended as an introduction to *** LaTeX specific export settings
> You are right, we can mostly remove them. I added a sentence at the
> beginning of the text in that section.
> I hope this small additions makes reading a bit easier.
>
> >
> > > While the details are covered in-depth in this section, here are some
> > > quick references to variables for the impatient: for engines, see
> > > ~org-latex-compiler~; for build sequences, see
> > > ~org-latex-pdf-process~; for packages, see
> > > ~org-latex-default-packages-alist~ and ~org-latex-packages-alist~.
> >
> > Probably, we can refer to ~org-latex-multi-lang-driver~ in this
> > paragraph as a short reference.
>
> Done
>
> BTW, reading there:
> >That's because LaTeX itself depends
> > on blank lines to tell apart syntactical elements, such as paragraphs.
>
> Couldn't we simplify this to:
> > That's because LaTeX itself depends
> > on blank lines to separate paragraphs.
>
> > > +- =LANGUAGE= ::
> > > + #+cindex: @samp{LANGUAGE}, keyword
> > > + #+vindex: org-latex-packages-alist
> > > + #+vindex: org-latex-language-alist
> > > + #+vindex: org-export-default-language
> > > +
> > > + Language code of the primary document language. When =LANGUAGE=
> > > + keyword is not specified use the value of
> > > + ~org-export-default-language~ (by default - =en=, American English)
> > > +
> > > + The list of language codes supported by Org is stored in the
> > > + variable ~org-latex-language-alist~.
> > > +
> > > - =LATEX_MULTI_LANG= ::
> >
> > I previously suggested "... merging description of LANGUAGE and
> > LATEX_MULTI_LANG into one record, similar to =LATEX_HEADER=,
> > =LATEX_HEADER_EXTRA=, but you did it differently, not merging
> > descriptions into a single description. Why?
>
> I just moved them to be next to one another, right. I hesitated to merge them
> because there are situations where #+LANGUAGE is /just/ informative.
>
> > >> Also, since we now allow multiple languages to be listed in #+LANGUAGE,
> > >> we may need to update the manual when talking about #+LANGUAGE keyword
> > >> in other places as well; not just in latex export section.
> > You seemingly did not address this comment.
> I'll keep that in the TODO for later (today).
>
> > > #+BEGIN_SRC elisp :results output :exports both
> > > - ("math" :font "TeX Gyre Termes Math")
> > > +(setq-default org-latex-fontspec-config
> > > + '(("main" :font "FreeSerif")
> > > + ("sans" :font "FreeSans")
> > > + ("mono" :font "Tex Gyre Cursor")
> > > + ("math" :font "TeX Gyre Termes Math")))
> > > #+END_SRC
> >
> > Please do the same in all the other examples you provide in the manual.
> OK, makes sense... I keep the polyglosssia part in my TODO for later today...
> >
> > > +[fn:49] Consult
> > > +[[https://www.gnu.org/software/emacs/manual/html_node/emacs/Directory-Variables.html][Per-Directory
> > > +Local Variables]] to learn to define and use directory local variables.
> >
> > In the review, I asked to use info: link, not a web link. Any reason you
> > went with web link?
> That went through the sieve in the "heat of the battle"... sorry.
> Maybe that I'm more used to providing Web links in my lecture notes
> and slides...
> Fixed...
> >
> > --
> > Ihor Radchenko // yantar92,
> > Org mode maintainer,
> > Learn more about Org mode at <https://orgmode.org/>.
> > Support Org development at <https://liberapay.com/org-mode>,
> > or support my work at <https://liberapay.com/yantar92>
>
> I'm pushing the "simpler things right now. The rest to follow...
>
> Best, /PA
>
> --
> Fragen sind nicht da, um beantwortet zu werden,
> Fragen sind da um gestellt zu werden
> Georg Kreisler
>
> Sagen's Paradeiser, write BE!
> Year 1 of the New Koprocracy
--
Fragen sind nicht da, um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler
Sagen's Paradeiser, write BE!
Year 1 of the New Koprocracy
