"Andros Fenollosa" <[email protected]> writes:

> Thanks for the detailed review. Please find attached an updated patch
> that addresses all the points you raised:
>
> 1. Added the "Project heartbeat" section to es/index.org. While at it, I
>    also added the "Mobile/Web" highlight and the source-code mirror
>    badge, and fixed the author banner.
> 2. Synced es/tools.org with tools.org: the "Android, iOS and web"
>    section, Emacs, hop, Orgy, Scrim, Captee and the second Clojure
>    parser. I dropped the Logseq entry to match the English page.
> 3. Added the ORG-NEWS #+INCLUDE and the kbd macro to es/Changes.org.
> 4. Added the missing #+description lines.
> 5. Fixed the broken manual and guide links in es/quickstart.org.
> 6. Replaced the leftover full-width colon (and other CJK punctuation and
>    text) with proper Spanish.

Thanks!

> I also added the "es" language link to the root and zh-CN preambles, and
> structured the patch like the zh-CN translation: only the .org sources,
> org-demo.html and the resources/ links are tracked, while the generated
> .html pages are ignored via es/.gitignore.

What is the motivation of adding .gitignore? We do not have it for the
rest of the orgweb repo.

> The Spanish translation is by Laura (in Cc); I helped with the technical
> side.

May I know if Laura had a chance to complete the FSF copyright
assignment? As I mentioned earlier, our main website requires the
assignment. Instructions in 
https://orgmode.org/worg/org-contribute.html#copyright

> Subject: [PATCH] Add Spanish (es) translation of the website
>
> Translate the orgmode.org pages into Spanish under es/, mirroring the
> layout of the existing zh-CN translation (only the .org sources,
> org-demo.html and the resources/ links are tracked; generated .html
> pages are ignored via es/.gitignore).
>
> This incorporates the mailing list review feedback:
>
> * es/index.org: Add the "Project heartbeat" section, the "Mobile/Web"
>   highlight and the source-code mirror badge; fix the author banner.
> * es/tools.org: Sync with tools.org (Android/iOS/web section, Emacs,
>   hop, Orgy, Scrim, Captee and the second Clojure parser); drop the
>   Logseq entry, matching the English page.
> * es/Changes.org: Add the ORG-NEWS #+INCLUDE and the kbd macro.
> * es/features.org, es/quickstart.org, es/manuals.org: Add the missing
>   #+description lines.
> * es/quickstart.org: Fix the broken manual and guide links.
> * es/org-demo.html, es/setup.org, es/manuals.org, es/index.org: Replace
>   leftover CJK text and punctuation with Spanish.
> * resources/preamble.html, zh-CN/resources/preamble.html: Add the es
>   language link.

These are the changes after the latest iteration of the review.
The commit message should instead describe overall changes made in the
patch.

> +++ b/es/index.org
> @@ -0,0 +1,301 @@
> +#+title: Org mode para GNU Emacs
> +#+setupfile: setup.org
> +#+language:  es

Since you specify language, we will also need a small update in
publish.sh for org-html-postamble-format. I could do it myself, but
since we need to adjust the commit message anyway, leaving this comment
here.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to