Sharad Mishra has posted comments on this change. Change subject: Handle missing/invalid mac address on import Vm/Template ......................................................................
Patch Set 5: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java Line 346: return false; Adding logic to check for MacPool does not go with the flow. You got a mac that is non-null, if VALIDATE_MAC_ADDRESS fails, false is returned. But if VALIDATE_MAC_ADDRESS passes then we check the MacPool to see if it has enough entries. Why? fillMacAddressIfMissing() is only getting mac address if mac is empty. So IMHO, the check for MacPool count should be moved out of this block and should be done only if getMacAddress() is empty. -- To view, visit http://gerrit.ovirt.org/5290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09dd86a352ecc17e80dceb8c331ec38f4fa96627 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
