Shahar Havivi has posted comments on this change. Change subject: Handle missing/invalid mac address on import Vm/Template ......................................................................
Patch Set 5: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java Line 346: return false; you right maybe the name is not that good but validateMacAddress() is called from CanDoAction() and we can fail the call, and the fillMacAddressIfMissing() is called from execute(). there is a race here... I will add another check in the fillMacAddressIfMissing() -- To view, visit http://gerrit.ovirt.org/5290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09dd86a352ecc17e80dceb8c331ec38f4fa96627 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
