Alona Kaplan has posted comments on this change. Change subject: userportal,webadmin: Builders infrastructure ......................................................................
Patch Set 9: I think the problem is we have common models (like UnitVmModel) that most of their usage logic resides in the list models (e.g VmListModel, UserPortalListModel), and therefore duplicated in each list model. In my opinion the solution should be to move that logic to the model itself (e.g. moving methods like VmListModel.Edit/OnSave to UnitVmModel). I have done this work for NetworkModel and VmInterfaceModel. All the list models that use these models just need to create the model and set the window. I think that if we do this for all the duplicate code in the list models, there will be no need for builders. -- To view, visit http://gerrit.ovirt.org/10874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If81d4c71f9feebd6ececb9a2be46b353383046de Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
