Tomas Jelinek has posted comments on this change. Change subject: userportal,webadmin: Builders infrastructure ......................................................................
Patch Set 9: Well, in some case it is enough to extract to the model, but in some case the concerns are pretty much cross cutting (and it will get even more visible with the introduction of the new Instance Types and Images entitites). Consider the following example: - for example new VM dialog, you change the selection of the template. It is the logical responsibility of the NewVmModelBehavior to catch this event. And it is it's responsibility to say what has to be copied from where to where. And you can not have method like "onTemplateChanged(VmTemplate template)" on UnitVmModel, because you expect slightly different reaction to it in e.g. NewVmModelBehavior and NewPoolModelBehavior (consider vmType which is set for VM and not for pool). So the most of the logic is copy/pasted, but there are differences. This is where the small builders come in place, where the most you can reuse and a small differences you specialize. Also, this two solutions are not against each other, there are pretty much complementary... -- To view, visit http://gerrit.ovirt.org/10874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If81d4c71f9feebd6ececb9a2be46b353383046de Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
