Tomas Jelinek has posted comments on this change. Change subject: webadmin: Network builders ......................................................................
Patch Set 4: Because the "new VM dialog" will contain a part where you will be able to select a NIC and assign it to a logical network. Also this dialog will create a new NIC if the instance type on which your VM is based on has no NICs defined. But it will be INSIDE the new VM dialog (e.g. it will aggregate also this logic). The new VM dialog (well, the model behind) can not extend the models behind the new network dialog. If you don't want builders here, I can remove the builders and extract that logic to a static class (which I extremely dislike because it is an antipattern for lots of reasons). Or you can propose a different solution. And why are the instance types that special? Well, because they aggregate lots of properties which are normally distributed in different parts of the system (like the networking you see here, in the future maybe also storage - adding disks in the new VM dialog etc). This are cross cutting concerns which can not be modularized by plain inheritance. -- To view, visit http://gerrit.ovirt.org/13918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icae2963687ad7978c3caa026e7062e7a1937d320 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
