Alona Kaplan has posted comments on this change. Change subject: webadmin: Network builders ......................................................................
Patch Set 4: I agree that util class with static methods is a very bad idea. This is not what I suggested. I suggested to use something like vm behaviours. The behaviours have instances and inheritance can be used. Just instead of having hundreds pieces of code- which is the result of the builders oriented design. All the common code (and there is not so much) will be organized in one place. It is unreadable to have a class per method. Using builders everywhere make the code to look like a thousand pieces puzzle. About the chaining. I don't see its advantages in this case. I see just one big disadvantage- the code looks like a long unreadable line. Can you please explain what are the benefits? -- To view, visit http://gerrit.ovirt.org/13918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icae2963687ad7978c3caa026e7062e7a1937d320 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
