Daniel Erez has posted comments on this change. Change subject: webadmin: Network builders ......................................................................
Patch Set 4: I would prefer that you didn't submit this I understand the need for code re-usage in favor of instance types dialogs. Some widgets/logic could indeed be shared to ease the implementation of instance type dialog. Creating a static utility class is obviously not the proper solution. However, I also think that the massive utilization of buliders here is a real overkill. This kind of builders inflation is exactly what I was so worried about when we introduced the infrastructure. I find this re-factor of existing models a bit to intrusive and the resulting code as less intuitive. As an alternative, I suggest to adopt other convention in our code. Trying a behaviour-like approach here is really worth a try, as Alona suggested. [Or, like we sometimes utilize in such cases, just extract the common code to a base model class.] What do you think? Can we compromise on the heavy use of builders through every model? -- To view, visit http://gerrit.ovirt.org/13918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icae2963687ad7978c3caa026e7062e7a1937d320 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
