Tomas Jelinek has posted comments on this change. Change subject: webadmin: Network builders ......................................................................
Patch Set 4: This was actually the first thing I have tried to do :) It is problematic because of the following reasons: - Network model has it's own logic and purpose which is quite diffrent from what I need. For example it needs the sourceListModel to call setWindow(null) and also things like setTitle(...) etc. Lot's of logic which has no meaning for me and can cause nice problems to me. - Network model is a window model e.g. it contains logic to set up *it's* window which is not the case for me and also it is logically incorrect to use it in a different way - Network models work with one nic. I need to work with a list (yes, could have something like a list of nic models) - There are some listeners on the model doing some stuff - would need to be careful what - I need also a "null network" so something like "no network selected to this nic" There are also other problems I have faced but don't remember what, would have to investigate more deeply. At the end of the day, to do it correctly, I would have to refactor your models quite a lot just to make them usable to me. Or, you know, I can extract the common logic to small standalone, reusable classes ;) -- To view, visit http://gerrit.ovirt.org/13918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icae2963687ad7978c3caa026e7062e7a1937d320 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
