Alona Kaplan has posted comments on this change. Change subject: webadmin: Network builders ......................................................................
Patch Set 4: I prefer to move the common code to one helper class (maybe something like the vm behaviours classes) and not to a lot of small classes. I think it"ll make the code more maintainable and readable. InitEditSelectedNetworkBuilder sounds more like a method name and not a class name. I think it makes more sense to put its code as a method in a bigger class. -- To view, visit http://gerrit.ovirt.org/13918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icae2963687ad7978c3caa026e7062e7a1937d320 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
