Noam Slomianko has uploaded a new change for review. Change subject: engine: add comment field to DataCenter (WIP) ......................................................................
engine: add comment field to DataCenter (WIP) As part of the Free Text FRE Does not include Sorting and REST api yet Added to the entities flow in the system DB <-> DAO <-> Entity <-> Model <-> UI Varified at entity level and at the model level Change-Id: I4168a782074af1bbd5b89b5a0564b44cb301f82f Bug-Url: https://bugzilla.redhat.com/610501 Signed-off-by: Noam Slomianko <[email protected]> --- M backend/manager/dbscripts/storages_sp.sql A backend/manager/dbscripts/upgrade/03_03_0150_add_comment_storage_pool.sql M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/OvfDataUpdaterTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StoragePoolValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDataCenterView.java 16 files changed, 77 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/78/14878/1 diff --git a/backend/manager/dbscripts/storages_sp.sql b/backend/manager/dbscripts/storages_sp.sql index 436a470..2c2e822 100644 --- a/backend/manager/dbscripts/storages_sp.sql +++ b/backend/manager/dbscripts/storages_sp.sql @@ -4,6 +4,7 @@ Create or replace FUNCTION Insertstorage_pool(v_description VARCHAR(4000), + v_comment VARCHAR(4000), v_id UUID, v_name VARCHAR(40), v_storage_pool_type INTEGER, @@ -15,8 +16,8 @@ RETURNS VOID AS $procedure$ BEGIN -INSERT INTO storage_pool(description, id, name, storage_pool_type,status,master_domain_version,spm_vds_id,compatibility_version,quota_enforcement_type) - VALUES(v_description, v_id, v_name, v_storage_pool_type,v_status,v_master_domain_version,v_spm_vds_id,v_compatibility_version,v_quota_enforcement_type); +INSERT INTO storage_pool(description, comment, id, name, storage_pool_type,status,master_domain_version,spm_vds_id,compatibility_version,quota_enforcement_type) + VALUES(v_description, v_comment, v_id, v_name, v_storage_pool_type,v_status,v_master_domain_version,v_spm_vds_id,v_compatibility_version,v_quota_enforcement_type); END; $procedure$ LANGUAGE plpgsql; @@ -25,6 +26,7 @@ Create or replace FUNCTION Updatestorage_pool(v_description VARCHAR(4000), + v_comment VARCHAR(4000), v_id UUID, v_name VARCHAR(40), v_storage_pool_type INTEGER, @@ -40,7 +42,7 @@ AS $procedure$ BEGIN UPDATE storage_pool - SET description = v_description,name = v_name,storage_pool_type = v_storage_pool_type, + SET description = v_description, comment = v_comment, name = v_name,storage_pool_type = v_storage_pool_type, status = v_status,storage_pool_format_type = v_storage_pool_format_type,master_domain_version = v_master_domain_version, spm_vds_id = v_spm_vds_id,compatibility_version = v_compatibility_version, _update_date = LOCALTIMESTAMP,quota_enforcement_type=v_quota_enforcement_type @@ -49,6 +51,7 @@ LANGUAGE plpgsql; Create or replace FUNCTION Updatestorage_pool_partial(v_description VARCHAR(4000), + v_comment VARCHAR(4000), v_id UUID, v_name VARCHAR(40), v_storage_pool_type INTEGER, @@ -61,7 +64,7 @@ AS $procedure$ BEGIN UPDATE storage_pool - SET description = v_description,name = v_name,storage_pool_type = v_storage_pool_type, + SET description = v_description, comment = v_comment, name = v_name,storage_pool_type = v_storage_pool_type, storage_pool_format_type = v_storage_pool_format_type,compatibility_version = v_compatibility_version, _update_date = LOCALTIMESTAMP,quota_enforcement_type = v_quota_enforcement_type WHERE id = v_id; diff --git a/backend/manager/dbscripts/upgrade/03_03_0150_add_comment_storage_pool.sql b/backend/manager/dbscripts/upgrade/03_03_0150_add_comment_storage_pool.sql new file mode 100644 index 0000000..ba33393 --- /dev/null +++ b/backend/manager/dbscripts/upgrade/03_03_0150_add_comment_storage_pool.sql @@ -0,0 +1 @@ +select fn_db_add_column('storage_pool', 'comment', 'VARCHAR(4000) default '''''); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/OvfDataUpdaterTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/OvfDataUpdaterTest.java index 9c6b93f..2ad3762 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/OvfDataUpdaterTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/OvfDataUpdaterTest.java @@ -136,12 +136,14 @@ templates = new HashMap<Guid, VmTemplate>(); pool1 = new StoragePool("first sp", + "", Guid.NewGuid(), "storage_pool1", StorageType.NFS.getValue(), StoragePoolStatus.Up.getValue()); pool2 = new StoragePool("second sp", + "", Guid.NewGuid(), "storage_pool2", StorageType.NFS.getValue(), diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StoragePoolValidatorTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StoragePoolValidatorTest.java index ff7ece1..ccd04da 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StoragePoolValidatorTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StoragePoolValidatorTest.java @@ -40,6 +40,7 @@ public void setup() { storagePool = new StoragePool("test", + "", Guid.NewGuid(), "test", StorageType.UNKNOWN.getValue(), diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java index 09a0cf2..8a09555 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java @@ -146,7 +146,7 @@ } private void newPoolNameIsAlreadyTaken() { - when(spDao.get(any(Guid.class))).thenReturn(new StoragePool("foo", Guid.Empty, "foo", + when(spDao.get(any(Guid.class))).thenReturn(new StoragePool("foo", "", Guid.Empty, "foo", StorageType.NFS.getValue(), StoragePoolStatus.Up.getValue())); when(spDao.getByName(anyString())).thenReturn(createDefaultStoragePool()); } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java index 899ee8d..a04d32f 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java @@ -27,6 +27,9 @@ groups = { CreateEntity.class, UpdateEntity.class }) private String description; + @Size(max = BusinessEntitiesDefinitions.GENERAL_MAX_SIZE) + private String comment; + private int storagePoolType = StorageType.UNKNOWN.getValue(); private StorageFormatType storagePoolFormatType = null; @@ -50,12 +53,14 @@ public StoragePool() { description = ""; + comment = ""; masterDomainVersion = 0; } public StoragePool(String description, Guid id, String name, int storage_pool_type, int status) { this(); this.description = description; + this.comment = comment; this.id = id; this.name = name; setstorage_pool_type(StorageType.forValue(storage_pool_type)); @@ -71,6 +76,17 @@ public void setdescription(String value) { this.description = value; + } + + public String getComment() { + if (comment == null) { + comment = ""; + } + return comment; + } + + public void setComment(String value) { + this.comment = value; } @Override @@ -172,6 +188,7 @@ result = prime * result + ((id == null) ? 0 : id.hashCode()); result = prime * result + ((LVER == null) ? 0 : LVER.hashCode()); result = prime * result + ((description == null) ? 0 : description.hashCode()); + result = prime * result + ((comment == null) ? 0 : comment.hashCode()); result = prime * result + ((compatibilityVersion == null) ? 0 : compatibilityVersion.hashCode()); result = prime * result + masterDomainVersion; result = prime * result + ((name == null) ? 0 : name.hashCode()); @@ -199,6 +216,7 @@ return (ObjectUtils.objectsEqual(id, other.id) && ObjectUtils.objectsEqual(LVER, other.LVER) && ObjectUtils.objectsEqual(description, other.description) + && ObjectUtils.objectsEqual(comment, other.comment) && ObjectUtils.objectsEqual(getcompatibility_version(), other.getcompatibility_version()) && masterDomainVersion == other.masterDomainVersion && ObjectUtils.objectsEqual(name, other.name) diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java index e6e67f2..86f0eef 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java @@ -29,6 +29,7 @@ throws SQLException { StoragePool entity = new StoragePool(); entity.setdescription(rs.getString("description")); + entity.setComment(rs.getString("comment")); entity.setId(Guid.createGuidFromString(rs.getString("id"))); entity.setname(rs.getString("name")); entity.setstorage_pool_type(StorageType.forValue(rs @@ -130,6 +131,7 @@ public void save(StoragePool pool) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() .addValue("description", pool.getdescription()) + .addValue("comment", pool.getComment()) .addValue("id", pool.getId()) .addValue("name", pool.getname()) .addValue("storage_pool_type", pool.getstorage_pool_type()) @@ -149,6 +151,7 @@ public void update(StoragePool pool) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() .addValue("description", pool.getdescription()) + .addValue("comment", pool.getComment()) .addValue("id", pool.getId()) .addValue("name", pool.getname()) .addValue("storage_pool_type", pool.getstorage_pool_type()) @@ -169,6 +172,7 @@ public void updatePartial(StoragePool pool) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() .addValue("description", pool.getdescription()) + .addValue("comment", pool.getComment()) .addValue("id", pool.getId()) .addValue("name", pool.getname()) .addValue("storage_pool_type", pool.getstorage_pool_type()) diff --git a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java index 9cac119..061345e 100644 --- a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java +++ b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java @@ -105,6 +105,7 @@ random.nextString(10), random.nextString(10)) }, { new StorageDomainDynamic(random.nextInt(), Guid.NewGuid(), random.nextInt()) }, { new StoragePool(random.nextString(10), + "", Guid.NewGuid(), random.nextString(10), random.nextEnum(StorageType.class).getValue(), diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java index 0f6ec1f..0e24e935 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java @@ -240,6 +240,7 @@ StoragePool obj = new StoragePool(); obj.setdescription(instance.getdescription()); + obj.setComment(instance.getComment()); obj.setId(instance.getId()); obj.setname(instance.getname()); obj.setstorage_pool_type(instance.getstorage_pool_type()); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java index 924941e..a951d24 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java @@ -316,6 +316,7 @@ } model.getDescription().setEntity(dataCenter.getdescription()); + model.getComment().setEntity(dataCenter.getComment()); model.setOriginalName(dataCenter.getname()); AsyncDataProvider.getStorageDomainList(new AsyncQuery(this, @@ -703,6 +704,7 @@ // Save changes. dataCenter.setname((String) model.getName().getEntity()); dataCenter.setdescription((String) model.getDescription().getEntity()); + dataCenter.setComment((String) model.getComment().getEntity()); dataCenter.setstorage_pool_type((StorageType) model.getStorageTypeList().getSelectedItem()); dataCenter.setcompatibility_version((Version) model.getVersion().getSelectedItem()); dataCenter.setQuotaEnforcementType((QuotaEnforcementTypeEnum) model.getQuotaEnforceTypeListModel() diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java index 9753d73..d44e05c 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java @@ -98,6 +98,18 @@ privateDescription = value; } + private EntityModel privateComment; + + public EntityModel getComment() + { + return privateComment; + } + + public void setComment(EntityModel value) + { + privateComment = value; + } + private ListModel privateStorageTypeList; public ListModel getStorageTypeList() @@ -148,6 +160,7 @@ { setName(new EntityModel()); setDescription(new EntityModel()); + setComment(new EntityModel()); setVersion(new ListModel()); setStorageTypeList(new ListModel()); @@ -295,6 +308,8 @@ getDescription().validateEntity(new IValidation[] { new AsciiOrNoneValidation() }); + getComment().validateEntity(new IValidation[] { new AsciiOrNoneValidation() }); + // TODO: add this code to async validate. // string name = (string)Name.Entity; // if (String.Compare(name, OriginalName, true) != 0 && !DataProvider.IsDataCenterNameUnique(name)) @@ -303,7 +318,8 @@ // Name.InvalidityReasons.Add("Name must be unique."); // } - return getName().getIsValid() && getDescription().getIsValid() && getStorageTypeList().getIsValid() + return getName().getIsValid() && getDescription().getIsValid() && getComment().getIsValid() + && getStorageTypeList().getIsValid() && getVersion().getIsValid(); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java index a5828e2..0134e78 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java @@ -95,6 +95,7 @@ dataCenter = new StoragePool(); dataCenter.setname(dataCenterName); dataCenter.setdescription((String) dataCenterModel.getDescription().getEntity()); + dataCenter.setComment((String) dataCenterModel.getComment().getEntity()); dataCenter.setstorage_pool_type((StorageType) dataCenterModel.getStorageTypeList().getSelectedItem()); dataCenter.setcompatibility_version((Version) dataCenterModel.getVersion().getSelectedItem()); diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java index 7ae679e..eef001c 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java @@ -157,6 +157,9 @@ @DefaultStringValue("Description") String descriptionLabel(); + @DefaultStringValue("Comment") + String commentLabel(); + @DefaultStringValue("VM network") String vmNetworkLabel(); @@ -930,6 +933,9 @@ @DefaultStringValue("Description") String descriptionDc(); + @DefaultStringValue("Comment") + String commentDc(); + // Storage DC @DefaultStringValue("Domain Status in Data-Center") String domainStatusInDcStorageDc(); diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView.java index 42417ac..5af886c 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView.java @@ -45,6 +45,11 @@ @WithElementId EntityModelTextBoxEditor descriptionEditor; + @UiField + @Path(value = "comment.entity") + @WithElementId + EntityModelTextBoxEditor commentEditor; + @UiField(provided = true) @Path(value = "storageTypeList.selectedItem") @WithElementId @@ -93,6 +98,7 @@ void localize(ApplicationConstants constants) { nameEditor.setLabel(constants.nameLabel()); descriptionEditor.setLabel(constants.descriptionLabel()); + commentEditor.setLabel(constants.commentLabel()); storageTypeListEditor.setLabel(constants.dataCenterPopupStorageTypeLabel()); versionEditor.setLabel(constants.dataCenterPopupVersionLabel()); quotaEnforceTypeEditor.setLabel(constants.dataCenterPopupQuotaEnforceTypeLabel()); diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView.ui.xml b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView.ui.xml index dd851a8..11d430e 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView.ui.xml +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView.ui.xml @@ -13,6 +13,7 @@ <g:FlowPanel> <e:EntityModelTextBoxEditor ui:field="nameEditor" /> <e:EntityModelTextBoxEditor ui:field="descriptionEditor" /> + <e:EntityModelTextBoxEditor ui:field="commentEditor" /> <e:ListModelListBoxEditor ui:field="storageTypeListEditor" /> <e:ListModelListBoxEditor ui:field="versionEditor" /> <e:ListModelListBoxEditor ui:field="quotaEnforceTypeEditor" /> diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDataCenterView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDataCenterView.java index 6bb821b..b237cc3 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDataCenterView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDataCenterView.java @@ -87,6 +87,14 @@ }; getTable().addColumn(descColumn, constants.descriptionDc(), "300px"); //$NON-NLS-1$ + TextColumnWithTooltip<StoragePool> commColumn = new TextColumnWithTooltip<StoragePool>() { + @Override + public String getValue(StoragePool object) { + return object.getComment(); + } + }; + getTable().addColumn(commColumn, constants.commentDc(), "300px"); //$NON-NLS-1$ + getTable().addActionButton(new WebAdminButtonDefinition<StoragePool>(constants.newDC()) { @Override protected UICommand resolveCommand() { -- To view, visit http://gerrit.ovirt.org/14878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4168a782074af1bbd5b89b5a0564b44cb301f82f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
