Gilad Chaplik has posted comments on this change.
Change subject: engine: add comment field to DataCenter (WIP)
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java
Line 56: comment = "";
Line 57: masterDomainVersion = 0;
Line 58: }
Line 59:
Line 60: public StoragePool(String description, Guid id, String name, int
storage_pool_type, int status) {
missing comment in ctor
Line 61: this();
Line 62: this.description = description;
Line 63: this.comment = comment;
Line 64: this.id = id;
Line 80:
Line 81: public String getComment() {
Line 82: if (comment == null) {
Line 83: comment = "";
Line 84: }
why you need it?
Line 85: return comment;
Line 86: }
Line 87:
Line 88: public void setComment(String value) {
--
To view, visit http://gerrit.ovirt.org/14878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4168a782074af1bbd5b89b5a0564b44cb301f82f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
