Allon Mureinik has posted comments on this change.
Change subject: engine: add comment field to DataCenter
......................................................................
Patch Set 3: (1 inline comment)
Why enforce an empty comment instead of just allowing null?
....................................................
File backend/manager/dbscripts/upgrade/03_03_0150_add_comment_storage_pool.sql
Line 1: select fn_db_add_column('storage_pool', 'comment', 'VARCHAR(4000)
default ''''');
the empty string default baffles me - why not allow nulls?
--
To view, visit http://gerrit.ovirt.org/14878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4168a782074af1bbd5b89b5a0564b44cb301f82f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
