If so, why dot you leave the evas_textblock_cursor_format_is_visible_get() to return NULL if you think it must verify the fnode?
------------------------------------ -Regards, Hermet- -----Original Message----- From: "Tom Hacohen"<t...@stosb.com> To: <g...@lists.enlightenment.org>; Cc: Sent: 2013-10-04 (금) 02:51:01 Subject: [EGIT] [core/efl] master 01/01: Revert "evas/textblock - null check." tasn pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=82f5f78dac8d3055fe1e1c3431875250456887b9 commit 82f5f78dac8d3055fe1e1c3431875250456887b9 Author: Tom Hacohen <tom>@stosb.com> Date: Thu Oct 3 18:45:07 2013 +0100 Revert "evas/textblock - null check." I'm sorry, but those kind of commit messages are unacceptable for code I'm the only maintainer of. It's bad enough that to have them in the project in general, but this I won't accept. I wanted to review this commit, but the lack of explanation about what you are trying to fix and why you think this is the good fix prevents me from doing my job. However, without really looking too much into it, this commit looks wrong. evas_textblock_cursor_format_is_visible_get should verify there's a format node... Please come up with a better commit message and re-commit. This reverts commit fe33aa74084aa383fb880ce9a32fa17663c41346. --- src/lib/evas/canvas/evas_object_textblock.c 1 - 1 file changed, 1 deletion(-) diff --git a/src/lib/evas/canvas/evas_object_textblock.c b/src/lib/evas/canvas/evas_object_textblock.c index de53f11..021f59a 100644 --- a/src/lib/evas/canvas/evas_object_textblock.c +++ b/src/lib/evas/canvas/evas_object_textblock.c @@ -8887,7 +8887,6 @@ evas_textblock_cursor_content_get(const Evas_Textblock_Cursor *cur) char *ret; fnode = _evas_textblock_node_visible_at_pos_get( evas_textblock_cursor_format_get(cur)); - if (!fnode) return NULL; buf = eina_strbuf_new(); _markup_get_format_append(buf, fnode); -- ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
