Yes there was a misunderstanding. I agree. But I didn't disagree on Tom's request and revert. I agree on him(lack of commit message) and you.
I just wondered one of the sentence in his revert comment. "I'm the only maintainer of. " "this commit looks wrong. evas_textblock_cursor_format_is_visible_get should verify there's a format node..." So I replied on the revert mail. "If so, why do you leave the evas_textblock_cursor_format_is_visible_get() to return NULL if you think it must verify the fnode?" Because the function is totally considered to return NULL. That's all. ------------------------------------ -Regards, Hermet- -----Original Message----- From: "Cedric BAIL"<cedric.b...@free.fr> To: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>; Cc: Sent: 2013-10-07 (월) 08:45:45 Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert "evas/textblock - null check." Hello, I think there is a misunderstanding here. One is describing what the patch does, the other want to know how to reproduce the bug that require this patch to be applied. In fact this has been a mistake we have been quite often in the past. Having commit message that basically duplicate the content of the code instead of explaining why are doing the change in the first place. Maybe we should formalize what we expect in a commit message so that this kind of misunderstanding doesn't happen (and also in 3 years from now, we will be able to figure out why we did do that). Cedric On Sun, Oct 6, 2013 at 2:08 PM, ChunEon Park <hermet>@naver.com> wrote: > I don't agree that commit message bad. > > but fundamental problem is your maintained function. > > If you wanna blame to me, then please fix the function first. (if you really > think you are the textblock maintainer) > > ------------------------------------ > -Regards, Hermet- > > -----Original Message----- > From: "Tom Hacohen"<tom.hacohen>@samsung.com> > To: <enlightenment-devel>@lists.sourceforge.net>; > Cc: > Sent: 2013-10-04 (금) 21:59:15 > Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert "evas/textblock > - null check." > > On 04/10/13 13:09, ChunEon Park wrote: >> it shouldn't be in. maybe. >> >> but you made the function to return NULL. >> >> and then you want to know reason by other people? >> > > Maybe it should, maybe it shouldn't the point is, I don't know. You are > now trying to explain yourself in the ML, why not explain what you were > trying to fix in the commit message itself? > > I didn't do anything, you did this commit. I have no idea what you are > talking about, what NULL I was returning and what reasons you are > talking about. > > As Sachiel said: explain what you were trying to do in the commit > message so people can actually review and understand what you were > trying to do. > > As for this commit: please explain what you mean and why you added this > fix, but this is unrelated to the discussion at hand. The discussion is > about the bad commit message that made it impossible for me to review > your patch. > > -- > Tom. > > > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Cedric BAIL ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
