/**
* @internal
* Returns the visible format at a specific location.
*
* @param n a format at the specific position.
* @return the format node at the specific position or NULL if not found.
*/
static Evas_Object_Textblock_Node_Format *
_evas_textblock_node_visible_at_pos_get(const Evas_Object_Textblock_Node_Format
*n)
{
....
}
I think the problem is not the commit and commit message.
But the function does
------------------------
-Regards, Hermet-
-----Original Message-----
From: "Iván Briano"<sachi...@gmail.com>
To: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>;
Cc:
Sent: 2013-10-04 (금) 21:52:28
Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert "evas/textblock -
null check."
On Fri, Oct 4, 2013 at 9:09 AM, ChunEon Park <hermet>@naver.com> wrote:
> it shouldn't be in. maybe.
>
> but you made the function to return NULL.
>
> and then you want to know reason by other people?
The point is to properly explain in the commit message the reason for
the commit.
>
> ------------------------------------
> -Regards, Hermet-
>
> -----Original Message-----
> From: "Tom Hacohen"<tom.hacohen>@samsung.com>
> To: <enlightenment-devel>@lists.sourceforge.net>;
> Cc:
> Sent: 2013-10-04 (금) 19:59:02
> Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert "evas/textblock
> - null check."
>
> On 03/10/13 19:02, ChunEon Park wrote:
>> If so,
>> why dot you leave the evas_textblock_cursor_format_is_visible_get() to
>> return NULL if you think it must verify the fnode?
>
> You missed the whole point of the revert. The point of the revert was my
> inability to review your patch, and thus I couldn't assure it should be
> kept in. Looking at it, it feels like it sholudn't be in, and without
> proper explanation, I couldn't have been convinced.
>
> Maybe it doesn't verify the node, I don't remember, but again, read up.
>
> --
> Tom.
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
