On 29.03.2013 13:25, Michael T. Pope wrote: > On Fri, 29 Mar 2013 10:01:57 AM Michael Vehrs wrote: > >> As far as I can tell, the generalized production code mostly works. >> > The backward compatibility is flakey. If I bring up my standard test game > none of the building production works. The colony tiles look good though. >
That is probably because Buildings are further along the road to using generalized production. I'll have a look at that, though. > >> However, it is only used for calculating the actual production at the >> moment. Any number of methods that calculate the potential production of >> tiles, tile types, unit types and so on still use the old production >> code. I intend to migrate these methods by and by. As a side effect, I >> think it might be possible to get rid of >> FreeColGameObjectType.applyDifficultyLevel(), which is mostly used to >> determine the primary and secondary production of tile types. >> > Cool. applyDifficultyLevel is a bit of a wart. > Yes, it is. > I have some lurking fail still with the option serialization. When that is > fixed I will either be up to the FreeColGameObject tree where the ugliest > stuff > is, or the AI tree which should be in reasonable shape. Since we are heading > for a save format flag day, this seems like a good time to cut the FCGOs and > AIOs over to using ID_ATTRIBUTE_TAG ("id"). Then we can drop ID_ATTRIBUTE > ("ID") completely in 0.11.x-successor. Any thoughts? > > Cheers, > Mike Pope > The sooner the better. There are probably several things that should be cleaned up on flag day. Various elements based on abstract goods might be unified, and the same might be true for several different production elements. I would also like to move the unattended production of buildings into the production element as far as the specification is concerned. Internally, it should probably still be handled as a modifier. In this context, "colonyCenterTile" should probably be replaced by the more neutral "unattended". By the way, should I chuck out any 0.9.x compatibility code I find along the way? Regards Michael ------------------------------------------------------------------------------ Own the Future-Intel(R) Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo contest. Compete for recognition, cash, and the chance to get your game on Steam. $5K grand prize plus 10 genre and skill prizes. Submit your demo by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2 _______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers