Hi,
I know, its a good thing unrelated classes like anything inside client, client.controller, client.networking packages only depend on a single GUI class.
I looked at the classes importing GUI and about half of these classes are in subpackages client.gui.* like panel, menu, option, which have no
real need to route their calls through it and often depend on Swing already. I'll try to take a closer look at those and see if circular dependencies
can be reduced that way.
Regards
wintertime
Gesendet: Montag, 09. März 2015 um 20:32 Uhr
Von: "Paolo Bizzarri" <pibi...@gmail.com>
An: win...@genial.ms
Cc: "FreeCol Developers" <freecol-developers@lists.sourceforge.net>
Betreff: Re: Re: [Freecol-developers] The size of dialogs
Von: "Paolo Bizzarri" <pibi...@gmail.com>
An: win...@genial.ms
Cc: "FreeCol Developers" <freecol-developers@lists.sourceforge.net>
Betreff: Re: Re: [Freecol-developers] The size of dialogs
On Mon, Mar 9, 2015 at 5:18 PM, <win...@genial.ms> wrote:
Hi,the GUI class is really the class I feel is violating SRP most. I got the feeling it could be split it into, for example:
GUI was there for a good reason - to create a facade that was hiding the whole GUI stuff from the rest of the application. It had to hide all the details originally expose.
Ideally, you want to replace just the GUI class with another implementation and change the GUI - the original plan was to make a version that could use a web browser instead of a Swing GUI.
That said
- splitting is good, but before we need to remove lots of painful internal dependencies.
- there is lots of code in the wrong place, that I suspect is causing many of the issues we are seeing in the GUI.
I hope tonight to send some initial patches. I need to make my way inside git.
Regards.
Paolo
------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
